Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp393301pxu; Tue, 1 Dec 2020 14:05:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzaMt43pFlBcEd6ag+WKofGnRdXpNhpX76Uo9mXiaszNGhLlTvgzArd5C/WoBx/vipnjsRA X-Received: by 2002:a05:6402:22ea:: with SMTP id dn10mr5142636edb.67.1606860328198; Tue, 01 Dec 2020 14:05:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606860328; cv=none; d=google.com; s=arc-20160816; b=utmOdeUCk0habcZFfWSbtaJJLNxEmaNxxfCa8DsCq+f3HxHdDZRjXMedMWoBltKlo3 zUv2VYDbFqho2Bappzo5VM1QDFl0GHDQOvhxugO6cNq4FuTTAjnlZsvCPo2bfLbbujEU /MY/aGIUhxjjMIHRMG6CZNJyRaaWJF3LaHWCqbLjB3xMDMVHT1wsMFjxUZ66C89j87tD GlRtQ97x3BqkgH7k+fnL6LlEQ6L4dq1YhC87CEQqWQr6VT3aBHQxIMr6+UjSbTn04pQ+ T3/Fqk2HUihIc51GsZT1J9sOp+IcPuWnQwlfjhoiwYvso7fB2EWTTbUO3F/NGbz7/PV+ pZ/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lfGhy2JUcyegyc0aFS8EotN0T98+OHZiPmiyVcAHfg0=; b=szokGED72kM5dWIJYaqgifUn/pT1d5e524ijaiHQsd6d8klUfip09fYlB7t8hG13hW LqmGgzVDqMgNpnA5U/mI4BXnQBRXwo42Q7xpbJPoqp/UKvFje3pXN1Jkhtjj1JBiuQtD +obuahX0j2O08PvcGJgyS0njQM2F/CI/ajOg55zyLBguyiYodxMUzPhliR12mj9jhdn9 4xRJM5V4k++DopdnW1HlIL0AdB5NcYFXZZxazA4n/YtRHIp/zBIw9AWbrPihZfgjp4mr huHgdltWjLM9SLHqfidg2dNqB4A/Vzl2E6rLwj9Vdy+fSF8aCbGATonm6DsYTHe3ZNj7 2Iag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=YUN682Vi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s17si777875edt.578.2020.12.01.14.05.05; Tue, 01 Dec 2020 14:05:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=YUN682Vi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404276AbgLAWCg (ORCPT + 99 others); Tue, 1 Dec 2020 17:02:36 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:46650 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388514AbgLAV7x (ORCPT ); Tue, 1 Dec 2020 16:59:53 -0500 Received: from pps.filterd (m0109333.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0B1LpZDU001936 for ; Tue, 1 Dec 2020 13:59:12 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=lfGhy2JUcyegyc0aFS8EotN0T98+OHZiPmiyVcAHfg0=; b=YUN682ViOsKtELQ9MUshaX9Iuf4CC7FiAgHZCg9rU/0vDP8Xf6ajColpNVvIRj8Qi2Sj ckl0+Ng1BKjYDKqBizk0TajatPSarrdFqaAcVtOa0NoW0LtsMI66IqS+WcJFfredJH0q 9wvfvHNr+SXhMXrKIqUP4+3VkgIKf1i0hTg= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com with ESMTP id 355qvjk193-20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Dec 2020 13:59:12 -0800 Received: from intmgw002.06.prn3.facebook.com (2620:10d:c085:208::f) by mail.thefacebook.com (2620:10d:c085:21d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 1 Dec 2020 13:59:10 -0800 Received: by devvm3388.prn0.facebook.com (Postfix, from userid 111017) id 8957719702BE; Tue, 1 Dec 2020 13:59:06 -0800 (PST) From: Roman Gushchin To: CC: , , , , , , , Subject: [PATCH bpf-next v9 16/34] bpf: refine memcg-based memory accounting for sockmap and sockhash maps Date: Tue, 1 Dec 2020 13:58:42 -0800 Message-ID: <20201201215900.3569844-17-guro@fb.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20201201215900.3569844-1-guro@fb.com> References: <20201201215900.3569844-1-guro@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-12-01_11:2020-11-30,2020-12-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 suspectscore=13 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 phishscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012010131 X-FB-Internal: deliver Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Include internal metadata into the memcg-based memory accounting. Also include the memory allocated on updating an element. Signed-off-by: Roman Gushchin --- net/core/sock_map.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/core/sock_map.c b/net/core/sock_map.c index ddc899e83313..153652a582ee 100644 --- a/net/core/sock_map.c +++ b/net/core/sock_map.c @@ -39,7 +39,7 @@ static struct bpf_map *sock_map_alloc(union bpf_attr *a= ttr) attr->map_flags & ~SOCK_CREATE_FLAG_MASK) return ERR_PTR(-EINVAL); =20 - stab =3D kzalloc(sizeof(*stab), GFP_USER); + stab =3D kzalloc(sizeof(*stab), GFP_USER | __GFP_ACCOUNT); if (!stab) return ERR_PTR(-ENOMEM); =20 @@ -975,8 +975,9 @@ static struct bpf_shtab_elem *sock_hash_alloc_elem(st= ruct bpf_shtab *htab, } } =20 - new =3D kmalloc_node(htab->elem_size, GFP_ATOMIC | __GFP_NOWARN, - htab->map.numa_node); + new =3D bpf_map_kmalloc_node(&htab->map, htab->elem_size, + GFP_ATOMIC | __GFP_NOWARN, + htab->map.numa_node); if (!new) { atomic_dec(&htab->count); return ERR_PTR(-ENOMEM); @@ -1116,7 +1117,7 @@ static struct bpf_map *sock_hash_alloc(union bpf_at= tr *attr) if (attr->key_size > MAX_BPF_STACK) return ERR_PTR(-E2BIG); =20 - htab =3D kzalloc(sizeof(*htab), GFP_USER); + htab =3D kzalloc(sizeof(*htab), GFP_USER | __GFP_ACCOUNT); if (!htab) return ERR_PTR(-ENOMEM); =20 --=20 2.26.2