Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp402332pxu; Tue, 1 Dec 2020 14:21:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYLTF46s0gSTISNsPK2rwo7DbnLyk9R+YATkPwTESd7knUoEOM0I+8DxLJkhTPNQ7vF02H X-Received: by 2002:a17:906:7f11:: with SMTP id d17mr5230182ejr.534.1606861267110; Tue, 01 Dec 2020 14:21:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606861267; cv=none; d=google.com; s=arc-20160816; b=x1oBtol+/SZ0YiXOo5M4mvQMlG9H/7B1lzXRozaQfETqVj39J4iiqN6LDJZ4y2bsDJ 1Qx0X+Z56M9vQQyX/4FJSAUybOE87up9HKgiEjziRhcVBHHDlZ29R9v9LCG1Cs4uxjG+ BQ5ZbrBM3xTuFl4JsVvFWahmnnTlF3RDIbfgLyPq05io4PCKOQ9Hjg0J+I2u0f+ZPqKD J2Ub15xcFxK6NggsNafGfSTNXqHc+3apedWr65KqxASeA9ZJnXQpNBE2os4EvtY6XGeG ZNkGXcB1AUMu3ZowZsu6qgfr3q87KLYkqaCQABF/Gf2M37FAd5hCc4XV+/KOCWLI0FbA EF0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IebKvdb3tH5Ws9T2pK+lAUzVv8if6GotR9k7lhmfVBo=; b=RBKmab7Sn1xRvDLyHPQcWXg+7HMvP4MTjWM+Dq3FqdPhFikGMEHOS2hOcFHjTWpCP8 qSwNZeCvMHxA2R1wmnl6BEi3kJ1f/IILQVsnTmnCoro5pFziwAYoAfH0/cX8LEjLOJzv 5U6wIOgSWJEkYW0ek25N6SR17lLcgIZmBIHY7haPM0gZOYjZFq/00GeXrD7yg1GUukDc wilMO9xMeGfN1ZIij9hn97gXahbT9ZB7NBDqo46VN6VQXVi50Ykge64dBvU0pUrA1fTC oLR1UqM5YjHTDFMMfnRgS/gFs2U2F06aNxDcA0HwH6KyJ/Ifgn76axJjdA3Ddd1/6bVz /2BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=igYZ5TOX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si818011ejf.167.2020.12.01.14.20.44; Tue, 01 Dec 2020 14:21:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=igYZ5TOX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388635AbgLAJCS (ORCPT + 99 others); Tue, 1 Dec 2020 04:02:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:38996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387994AbgLAJCQ (ORCPT ); Tue, 1 Dec 2020 04:02:16 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2197D22252; Tue, 1 Dec 2020 09:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606813289; bh=esfKVzGDfYzkj7L+9e4oZSnTVgydKBnm7+UNunbg2+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=igYZ5TOXVgc5wbQJgHIz9KZ8owyHGACpb7VHYMW+hHd/aLCKfaRS5I3WNHULX9tGJ ZdeZAIkupLidtVC8SMA8oxY7NPI4Zt5YdhbFMhgJQBQxwQOUISLHEGrvcdceNDxjwW MAU5FZDLfo0PRScHO16DBecrYp9cH77DHL65uMCU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Benjamin Berg , Henrique de Moraes Holschuh , Hans de Goede , Sasha Levin Subject: [PATCH 4.19 46/57] platform/x86: thinkpad_acpi: Send tablet mode switch at wakeup time Date: Tue, 1 Dec 2020 09:53:51 +0100 Message-Id: <20201201084651.367647472@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201201084647.751612010@linuxfoundation.org> References: <20201201084647.751612010@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Benjamin Berg [ Upstream commit e40cc1b476d60f22628741e53cf3446a29e6e6b9 ] The lid state may change while the machine is suspended. As such, we may need to re-check the state at wake-up time (at least when waking up from hibernation). Add the appropriate call to the resume handler in order to sync the SW_TABLET_MODE switch state with the hardware state. Fixes: dda3ec0aa631 ("platform/x86: thinkpad_acpi: Implement tablet mode using GMMS method") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210269 Signed-off-by: Benjamin Berg Acked-by: Henrique de Moraes Holschuh Link: https://lore.kernel.org/r/20201123132157.866303-1-benjamin@sipsolutions.net Signed-off-by: Hans de Goede Signed-off-by: Sasha Levin --- drivers/platform/x86/thinkpad_acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 98bd8213b0378..8cc01857bc5c0 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -4251,6 +4251,7 @@ static void hotkey_resume(void) pr_err("error while attempting to reset the event firmware interface\n"); tpacpi_send_radiosw_update(); + tpacpi_input_send_tabletsw(); hotkey_tablet_mode_notify_change(); hotkey_wakeup_reason_notify_change(); hotkey_wakeup_hotunplug_complete_notify_change(); -- 2.27.0