Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp404962pxu; Tue, 1 Dec 2020 14:25:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzErDfQlNZUxjK3KmyltQJO54rA1ku+o+nB2/glUrnAT7patPoEGpG7hNVfLXduMkG52cn3 X-Received: by 2002:a50:d745:: with SMTP id i5mr5428516edj.166.1606861538688; Tue, 01 Dec 2020 14:25:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606861538; cv=none; d=google.com; s=arc-20160816; b=jHF+Wv/0sC40GATv0VFONxf87b94XK5NtzV+94kerl4X1mVB0fIttvodZXPrPtNkQo F7tWBw3chLyjKzJyKerATyUywuuTD5bD8EsQs1Pjw/GKwibyKn+ntvEm/FW2BYypgEq1 QHs7FAqiUImmNsNO9aXZHQjeEj+z26YH4Oi8NJvCurfiVncWjBpsikSgNY+HxXilaoCG tXa6el1Qv85ncPkcw/KSSwGOFGHasUSQHToXZlfMA3+iDCMd9XPgPyrQ2VfKCiwQqN10 HGzIUxNTfi3wlFs/UIaOXdES20Luv2RsaPx7jQUYAy8+cqc8UWcTy0oRNFsMrjIBs615 9Xzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=x1GwPNVY5HWx129EoPLD8bRXRjpi27Via8BFeaEuz7A=; b=09xe8TopTE2b9anNBviI3tszO/pKUEnh6UMbGyTYw+LhB+sF9X1Zr2uz7B6Mwj3XY9 wv0g3F9k7DE9YrtNkNRy2ieKBWKmLNlCwP+L06MnTuBNkEHXiWVCtF1dKfaawrXchVUi psANWMwOs39rhjs5ahql/78Mj8VES96PMad+UBu5e9uzfMVRsod0TqTdpm1nROVpn4bP Hghz1NKRwx7oKILyXAt8oGwryeoP6EQnW+K3oxr29oG3bGcpTYUx9tRNA+otfI8icS2l zWn6RBalhPagGIexbkrTgfob6OEgfpYuYa2kypJqXUOFgIaaOwiLwmy2k66wZI6pRGeK lUaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XgfAB4iq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 30si754822edv.385.2020.12.01.14.25.16; Tue, 01 Dec 2020 14:25:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XgfAB4iq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389316AbgLAJIq (ORCPT + 99 others); Tue, 1 Dec 2020 04:08:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:44634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389138AbgLAJHe (ORCPT ); Tue, 1 Dec 2020 04:07:34 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71D1120770; Tue, 1 Dec 2020 09:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606813614; bh=q59sevtrMVyBZfmwzgofnPBN0fl4y3DuaE+xVTlSLcM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XgfAB4iq6GrOnwUykFYXXLSQWM3Hb8nQE3I5w16AmX1vAcwsYbvVNLqxXABBJyohR WxhIH/juN4wS0UesmZl5++n+0cwzaW6re0f0fQWUTS+9GOYiyNC3h/vt7isN+YpSEK NluXdZy/wTZxrChjGivPiokPAChoVuRdK1aoS0n8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, mateusz.gorski@linux.intel.com, Cezary Rojewski" , Pierre-Louis Bossart , Mark Brown , Cezary Rojewski Subject: [PATCH 5.4 92/98] ASoC: Intel: Skylake: Select hda configuration permissively Date: Tue, 1 Dec 2020 09:54:09 +0100 Message-Id: <20201201084659.572055858@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201201084652.827177826@linuxfoundation.org> References: <20201201084652.827177826@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cezary Rojewski commit a66f88394a78fec9a05fa6e517e9603e8eca8363 upstream. With _reset_link removed from the probe sequence, codec_mask at the time skl_find_hda_machine() is invoked will always be 0, so hda machine will never be chosen. Rather than reorganizing boot flow, be permissive about invalid mask. codec_mask will be set to proper value during probe_work - before skl_codec_create() ever gets called. Signed-off-by: Cezary Rojewski Reviewed-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20200305145314.32579-3-cezary.rojewski@intel.com Signed-off-by: Mark Brown Cc: # 5.4.x Signed-off-by: Greg Kroah-Hartman --- sound/soc/intel/skylake/skl.c | 5 ----- 1 file changed, 5 deletions(-) --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -480,13 +480,8 @@ static struct skl_ssp_clk skl_ssp_clks[] static struct snd_soc_acpi_mach *skl_find_hda_machine(struct skl_dev *skl, struct snd_soc_acpi_mach *machines) { - struct hdac_bus *bus = skl_to_bus(skl); struct snd_soc_acpi_mach *mach; - /* check if we have any codecs detected on bus */ - if (bus->codec_mask == 0) - return NULL; - /* point to common table */ mach = snd_soc_acpi_intel_hda_machines;