Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp411903pxu; Tue, 1 Dec 2020 14:38:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvXZmpTDsVK1PQ6IcrsHWm+7wbSe4QupRFp2fa1PeKJlmm9lTWA7dbe4UgxBrwnysMaBpk X-Received: by 2002:a17:906:d41:: with SMTP id r1mr5116453ejh.383.1606862287585; Tue, 01 Dec 2020 14:38:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606862287; cv=none; d=google.com; s=arc-20160816; b=Yw+w2+V12bn4Jd42eZFmfO8OzIsreFuri0/0HbH2WJ+QLjv/QxryF8zgANsdVb8o1l COpDgNRB+Td+LoMfzD6sFVrTVoXZKz9x53bXIo1I6oR+xlT8tfRX4aJ5BtLa+2t6mOJ9 riTA3+zgVBgdQJEZ95bt8Cv5eqCbXBsMeP9SB8YdawOpi26qSo125M4fKvpScItHs1Vn wIS1qf1wr0M9ypwnSkl3J5QhZgeNGqUNyXtOeRZcUmfxh1NKIONXd9/aziO6gJLpi8jk 7wuO24mz0tAdZQNmNuthId0LOHFM6eYcUHUhNlz+oyPc/S/uQfibvltZZ4eGN5glgsHA 4XoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:dkim-signature; bh=CVcttZSpxINW4NuVhqPB6G7t6UvsVZ9u4U4hHH4fAUY=; b=H2JkFigd6buzGLkHPL/y+WdadvyFGAh4cEfKDYaTyHmz0iKIl8yfmNnf0avv9xvWCn ykwLuXZc+hs+6KVNsiOpsmX5T6zlljOCD06ScEXXzC0KdxYS6lWxc5KTohj7zfVBPnw+ TknuhlP+jiv1vog+6nAT65Mhl5PeXakLnf6edOfr4+HXC/v6aydezYnXWmwGP4674KjI 5lQ1tBSxssE4orRROwqG/t8IZVebKeWSZneGUtG4b8k26MPrYbjZKgVMbTRD5EStIyno QiIi8ZAIaqDOrx58laJK692cgYlJhzybWIewKzfy36r5d8we//T9x+wuvO/ReLKtTlOt pecg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BgB3WbMz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t5si816837edq.590.2020.12.01.14.37.45; Tue, 01 Dec 2020 14:38:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BgB3WbMz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728471AbgLARND (ORCPT + 99 others); Tue, 1 Dec 2020 12:13:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:45926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727368AbgLARNC (ORCPT ); Tue, 1 Dec 2020 12:13:02 -0500 Received: from localhost (cpc102334-sgyl38-2-0-cust884.18-2.cable.virginm.net [92.233.91.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5522206D8; Tue, 1 Dec 2020 17:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606842742; bh=LA/wyI+AskkviTCy4hXkk/OQ8SI/xkbgqynthnKkfrE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BgB3WbMzAIPQBd6ApotKIIDrl50qszhyaW2UkK+t8EHwqSRABA9g/yztKH3hOALVF U5WetMNXk9HG97zmBOeXIuSt+551K9WAAP13xTs33vDe9rIBB/ITd1iGCpkPZKY1li 9sWqzWIAxvsucj1nr+CQ8R7F+nXhjB+moOApdDw4= Date: Tue, 1 Dec 2020 17:11:53 +0000 From: Mark Brown To: "H. Nikolaus Schaller" Cc: Linus Walleij , Sven Van Asbroeck , kernel list , Laurent Pinchart , Discussions about the Letux Kernel Subject: Re: [BUG] SPI broken for SPI based panel drivers Message-ID: <20201201171153.GM5239@sirena.org.uk> Mail-Followup-To: "H. Nikolaus Schaller" , Linus Walleij , Sven Van Asbroeck , kernel list , Laurent Pinchart , Discussions about the Letux Kernel References: <2D7916FA-678F-4236-B478-C953CADF2FFA@goldelico.com> <4AC29229-9542-4E77-B993-217E29C7E209@goldelico.com> <20201201121620.GB5239@sirena.org.uk> <20201201162035.GK5239@sirena.org.uk> <8D0E8CDA-96EA-4900-B5B2-0AD371EAD046@goldelico.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WuedheRyq6FDfQ9j" Content-Disposition: inline In-Reply-To: <8D0E8CDA-96EA-4900-B5B2-0AD371EAD046@goldelico.com> X-Cookie: Who was that masked man? User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --WuedheRyq6FDfQ9j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 01, 2020 at 05:41:54PM +0100, H. Nikolaus Schaller wrote: > > Am 01.12.2020 um 17:20 schrieb Mark Brown : > > I think the problem here is more to do with where we started than where > > we're going or how we got there - things have been glued together or > > happened to work in ways that mean I'm not sure we reasonably understand > > the situation we started from or all the requirements it has. As you > > say I'm not sure anything beyond throwing the API away and starting > > afresh would really help here, but that's not really how we tend to do > > things for a bunch of very good reasons. > I think the key problem is GPIO_ACTIVE_HIGH 0 and GPIO_ACTIVE_LOW 1 > in device tree blobs. But that is so fundamental that we have to live with it. > So I guess that even a new API from scratch wouldn't improve that. Yeah, that's definitely part of it - more generally there's multiple places trying to determine if the signal is inverted with different interactions/expectations. Having it in an ABI definitely contributes a lot to causing trouble though. --WuedheRyq6FDfQ9j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/GeVgACgkQJNaLcl1U h9CPMQf/SsrwU3DUXaX7CJ7+bYc0OzNzeBvjKkMchBWxHcnEyR7EKhZwHXxNhxbq cH5SzVmeuM5I/HsQ0FGpI07ZRWo3nAUlA2QVEOjXYJ7fPFw/bMn10xi7KJzo2aNg gWjAJtp8PfaW2J+bjoVCcRxyS5ppsBNj5AmSHr1ZDxHee4TZUZ8MvlbMvBXGkt6L 4PO0uMJ79QY3KuNzKr+GnceyW+mhcGIuW9OSJepMx+yK2m4ZmsRKy9kduN7Rg0WJ ugMF9UY0qZHpsyXEjlgbaUJTOUBMZYhX36f6iUh3hHuTMZXrfEaoK3CEAj9jToYl d3aLIj3j80SU6HUmqHYfdkfAqmMcsA== =45IK -----END PGP SIGNATURE----- --WuedheRyq6FDfQ9j--