Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] gpiolib: do not print err message for EPROBE_DEFER
To:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
CC:     <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20201118142917.25752-1-grygorii.strashko@ti.com>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <69388132-1a81-e222-76fc-5d3b860a2d53@ti.com>
Date:   Tue, 1 Dec 2020 19:16:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201118142917.25752-1-grygorii.strashko@ti.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

hi Bartosz, All,

On 18/11/2020 16:29, Grygorii Strashko wrote:
> The gpiochip may have dependencies from pinmux and so got deferred. Now it
> will print error message every time -EPROBE_DEFER is returned which is
> unnecessary:
> 
> "gpiochip_add_data_with_key: GPIOs 0..31 (gpio-0-31) failed to register, -517"
> 
> Hence, do suppress error message for -EPROBE_DEFER case.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
>   drivers/gpio/gpiolib.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 089ddcaa9bc6..fd2c503a6aab 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -771,9 +771,11 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
>   	ida_free(&gpio_ida, gdev->id);
>   err_free_gdev:
>   	/* failures here can mean systems won't boot... */
> -	pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
> -	       gdev->base, gdev->base + gdev->ngpio - 1,
> -	       gc->label ? : "generic", ret);
> +	if (ret != -EPROBE_DEFER) {
> +		pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
> +		       gdev->base, gdev->base + gdev->ngpio - 1,
> +		       gc->label ? : "generic", ret);
> +	}
>   	kfree(gdev);
>   	return ret;
>   }
> 

Any comments for this patch?

Note. Modern dev_err_probe() seems can't be used as gpio_chip->parent is not guaranteed to be set and
it's not clear if chip_err() still can be used at this stage.

-- 
Best regards,
grygorii