Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964972AbWH2Nrc (ORCPT ); Tue, 29 Aug 2006 09:47:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750833AbWH2Nrc (ORCPT ); Tue, 29 Aug 2006 09:47:32 -0400 Received: from mx1.redhat.com ([66.187.233.31]:57043 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1750714AbWH2Nrb (ORCPT ); Tue, 29 Aug 2006 09:47:31 -0400 From: David Howells In-Reply-To: <200608281352.58281.arnd.bergmann@de.ibm.com> References: <200608281352.58281.arnd.bergmann@de.ibm.com> <20060825200455.GA2629@uranus.ravnborg.org> <20060825193707.11384.97372.stgit@warthog.cambridge.redhat.com> <22040.1156537104@warthog.cambridge.redhat.com> To: Arnd Bergmann Cc: David Howells , Sam Ravnborg , axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4] X-Mailer: MH-E 8.0; nmh 1.1; GNU Emacs 22.0.50 Date: Tue, 29 Aug 2006 14:47:16 +0100 Message-ID: <29516.1156859236@warthog.cambridge.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 538 Lines: 21 Arnd Bergmann wrote: > You could write it as > > bounce-$(CONFIG_MMU) += bounce.o > obj-$(CONFIG_BLOCK) += $(bounce-y) I could, yes, but why? What does it buy? I think this: ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy) obj-y += bounce.o endif is clearer. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/