Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qfPlIivmZ9R0/MiD3AMCBSg7SNhh5lZr5h5LcBFD9eViy/AhAPjhDRgnsgnCt+1audN/y0v6fZ
 cKfsTg59tC+A==
IronPort-SDR: nhjfwl1wyrL9S96FyxTBjmLY2G1FXKobY8fNTUjclrSGlo7OUwSoPEOljhB2np9rjA0soeqm8k
 8qCLpF4zA6lA==
Date:   Tue, 1 Dec 2020 22:36:57 -0800
From:   Andi Kleen <ak@linux.intel.com>
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org, Jin Yao <yao.jin@linux.intel.com>,
        John Garry <john.garry@huawei.com>,
        Paul Clarke <pc@us.ibm.com>, kajoljain <kjain@linux.ibm.com>,
        Stephane Eranian <eranian@google.com>,
        Sandeep Dasgupta <sdasgup@google.com>
Subject: Re: [PATCH v4 5/5] perf metric: Don't compute unused events.
Message-ID: <20201202063657.GC1363814@tassilo.jf.intel.com>
References: <20201202062646.3780002-1-irogers@google.com>
 <20201202062646.3780002-6-irogers@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201202062646.3780002-6-irogers@google.com>
Precedence: bulk

> +| expr '-' expr
> +{
> +	if (!compute_ids || (is_const($1.val) && is_const($3.val))) {
> +		assert($1.ids == NULL);
> +		assert($3.ids == NULL);
> +		$$.val = $1.val - $3.val;
> +		$$.ids = NULL;
> +	} else {
> +		/* LHS and/or RHS need computing from event IDs so union. */
> +		$$ = union_expr($1, $3);
> +	}

Can't this be all in a macro? It's still a lot of duplication.

I'm still not a fan, but I think with a macro it wouldn't be too bad.


-Andi