Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: sFhi2PLOeMR2FqbWHROti706EjvwTpZO3GEGdyRAoWBc/pWEURBnyooTgz4Gn32yG8wqhKlE+G
 fVsRuJcGKAHg==
IronPort-SDR: 6zOGQ4OUp/IhOQcWblEiSI5CyWmGZlxJZG7LbmCkqPjOo++OgKlAe76NffYmKTf4R39RA1Z+eD
 k2DkgMWOYaJw==
Date:   Tue, 1 Dec 2020 22:55:26 -0800
From:   Andi Kleen <ak@linux.intel.com>
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Jin Yao <yao.jin@linux.intel.com>,
        John Garry <john.garry@huawei.com>,
        Paul Clarke <pc@us.ibm.com>, kajoljain <kjain@linux.ibm.com>,
        Stephane Eranian <eranian@google.com>,
        Sandeep Dasgupta <sdasgup@google.com>
Subject: Re: [PATCH v4 5/5] perf metric: Don't compute unused events.
Message-ID: <20201202065526.GE1363814@tassilo.jf.intel.com>
References: <20201202062646.3780002-1-irogers@google.com>
 <20201202062646.3780002-6-irogers@google.com>
 <20201202063657.GC1363814@tassilo.jf.intel.com>
 <CAP-5=fVMuRCZEyG+s3z2gw3OvcDdtE1Kwe-7LG7uXOKfwmzFcA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAP-5=fVMuRCZEyG+s3z2gw3OvcDdtE1Kwe-7LG7uXOKfwmzFcA@mail.gmail.com>
Precedence: bulk

>      Can't this be all in a macro? It's still a lot of duplication.
> 
>      I'm still not a fan, but I think with a macro it wouldn't be too bad.
> 
>    Ugh, not a fan of macros. They expand to a single line of code and make
>    debugging hard. I'll do a v5 with a macro :-/

I suppose you could inlines with callbacks too, with one liner functions for
the operands.

-Andi