Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com;
Envelope-to: manish.narani@xilinx.com,
 tejas.patel@xilinx.com,
 rajan.vaja@xilinx.com,
 michal.simek@xilinx.com,
 linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 zou_wei@huawei.com,
 gregkh@linuxfoundation.org
Subject: Re: [PATCH -next v2] firmware: xilinx: Mark pm_api_features_map with
 static keyword
To:     Greg KH <gregkh@linuxfoundation.org>,
        Michal Simek <michal.simek@xilinx.com>
CC:     Zou Wei <zou_wei@huawei.com>, <rajan.vaja@xilinx.com>,
        <jolly.shah@xilinx.com>, <tejas.patel@xilinx.com>,
        <manish.narani@xilinx.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <1606823513-121578-1-git-send-email-zou_wei@huawei.com>
 <65ea30eb-2595-4af8-09c2-6d352b9be509@xilinx.com>
 <X8a067jdynVt3Lvg@kroah.com>
From:   Michal Simek <michal.simek@xilinx.com>
Message-ID: <9dbf2dd5-40db-3cbf-4d53-b027435ccbfe@xilinx.com>
Date:   Wed, 2 Dec 2020 08:31:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <X8a067jdynVt3Lvg@kroah.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2020 07:31:17.9186
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4489ad4a-a06b-4f14-2562-08d896944210
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: BL2NAM02FT020.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6070
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 01. 12. 20 22:26, Greg KH wrote:
> On Tue, Dec 01, 2020 at 01:03:59PM +0100, Michal Simek wrote:
>>
>>
>> On 01. 12. 20 12:51, Zou Wei wrote:
>>> Fix the following sparse warning:
>>>
>>> drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static?
>>>
>>> Signed-off-by: Zou Wei <zou_wei@huawei.com>
>>> ---
>>>  drivers/firmware/xilinx/zynqmp.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
>>> index d08ac82..fd95ede 100644
>>> --- a/drivers/firmware/xilinx/zynqmp.c
>>> +++ b/drivers/firmware/xilinx/zynqmp.c
>>> @@ -29,7 +29,7 @@
>>>  #define PM_API_FEATURE_CHECK_MAX_ORDER  7
>>>  
>>>  static bool feature_check_enabled;
>>> -DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>> +static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>>  
>>>  /**
>>>   * struct pm_api_feature_data - PM API Feature data
>>>
>>
>> The patch is good but I am missing fixed tag to get it to LTS.
> 
> Why is this needed for any stable kernel release?  It's a sparse
> warning, no one trips across those in stable kernels...

Ok thanks for explanation.

Applied to zynqmp/soc branch.

Thanks,
Michal