Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp737031pxu; Wed, 2 Dec 2020 01:56:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCeO7/Eo+OpHtBVG2u4LmbqD4k+B/JpIjV3bg5pf6Qrod4AQepj3zxtjIVDPPLnGV0iixc X-Received: by 2002:a05:6402:c84:: with SMTP id cm4mr1249047edb.360.1606902962856; Wed, 02 Dec 2020 01:56:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606902962; cv=none; d=google.com; s=arc-20160816; b=ggkdymL6q/6FdwwNQBnAFmuauIvYk7fbTs/Yl0ErUpR4GBux+ew15VIjn3lKr4h5lT 4RqwBi7iiLqnajhCRlF/Z0+Mh+N272kzYLmJx0KA8Cl1iAn9OCmlazSBYvXfT+Nncmwe SyKribgH0CSEqoAnwqxa55C/orfkQyZs5mAJA69oknfzKJVoVntRU0CviqlnfVXNO94g tkdNm05jWGYun+rj5L0fv6g6gWLfF936wl0ze084dl++/+XGpyCUpZ23Nq4JCYLEJTA0 /MX40nPwnK0bKCNXmOx68z99pgW+4x921GuyCG6ZKSJkwuczvPTCGu4OlZdh8GTeYxb9 /O6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=ch6IsjnWXizyxSul6l+Iq4xGrBqQjDI845O0+Opg/bA=; b=OLCM35eUgTWfrLrxoF+7VQL1qgRFj0mokdozXn0FMxlk50dWy63p86FOwFGvPBkekI /AI2r6FXBqivfht8Q4ilsL1cPYeH2D/2En9E+sFyK5GToz3EI+NAQhZwX0ZylltBSdLG hox5rIwk6X+YchkPfrgaT7oUp52Gfbb/D5cjU42GqzSlqFTVaGk/NcXyAWINC1IjaJXD /RRac4siREopdF6bRogEYciXH7OHCxFuEBfJUDGWG3Jut2szFAQVdzfMzZGvKsNqE9Ym +TjlW+7SpjlTcRm/G2H+dWtB1itdtEeXQB6cy2F6J79QAfSDIQ99qeq9oXUV1gTlDHjI wvFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jp24si540500ejb.371.2020.12.02.01.55.37; Wed, 02 Dec 2020 01:56:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728701AbgLBJxK (ORCPT + 99 others); Wed, 2 Dec 2020 04:53:10 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:8919 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbgLBJxJ (ORCPT ); Wed, 2 Dec 2020 04:53:09 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CmDlP2Y7jz76Vy; Wed, 2 Dec 2020 17:52:01 +0800 (CST) Received: from compute.localdomain (10.175.112.70) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 2 Dec 2020 17:52:24 +0800 From: Zhang Changzhong To: , , , , CC: , Subject: [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset() Date: Wed, 2 Dec 2020 17:56:05 +0800 Message-ID: <1606902965-1646-1-git-send-email-zhangchangzhong@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.70] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: b1fb1f280d09 ("cxgb3 - Fix dma mapping error path") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/chelsio/cxgb3/sge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c index e18e9ce..1cc3c51 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c @@ -3175,6 +3175,7 @@ int t3_sge_alloc_qset(struct adapter *adapter, unsigned int id, int nports, GFP_KERNEL | __GFP_COMP); if (!avail) { CH_ALERT(adapter, "free list queue 0 initialization failed\n"); + ret = -ENOMEM; goto err; } if (avail < q->fl[0].size) -- 2.9.5