Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 2 Dec 2020 11:55:04 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Stephen Hemminger <stephen@networkplumber.org>
Cc:     Michael Kelley <mikelley@microsoft.com>,
        Matheus Castello <matheus@castello.eng.br>, wei.liu@kernel.org,
        joe@perches.com, KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>, sashal@kernel.org,
        Tianyu Lan <Tianyu.Lan@microsoft.com>,
        Dexuan Cui <decui@microsoft.com>,
        Sunil Muthuswamy <sunilmut@microsoft.com>,
        linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING
Message-ID: <20201202115504.w52yeixpg7nbzw2v@liuwe-devbox-debian-v2>
References: <20201125032926.17002-1-matheus@castello.eng.br>
 <MW2PR2101MB105245D2BF9C9B5995D0188ED7F61@MW2PR2101MB1052.namprd21.prod.outlook.com>
 <20201129214328.254372dd@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201129214328.254372dd@hermes.local>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Sun, Nov 29, 2020 at 09:43:28PM -0800, Stephen Hemminger wrote:
> On Sun, 29 Nov 2020 08:51:47 -0800
> "Michael Kelley" <mikelley@microsoft.com> wrote:
> 
> > From: Matheus Castello <matheus@castello.eng.br> Sent: Tuesday, November
> > 24, 2020 7:29 PM
> > > 
> > > Checkpatch emits WARNING: quoted string split across lines.
> > > To keep the code clean and with the 80 column length indentation the
> > > check and registration code for kmsg_dump_register has been transferred
> > > to a new function hv_kmsg_dump_register.
> > > 
> > > Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> > > ---
> > > This is the V3 of patch 4 of the series "Add improvements suggested by
> > > checkpatch for vmbus_drv" with the changes suggested by Michael Kelley  
> > and
> > > Joe Perches. Thanks!
> > > ---
> > >  drivers/hv/vmbus_drv.c | 35 ++++++++++++++++++++---------------
> > >  1 file changed, 20 insertions(+), 15 deletions(-)
> > > 
> > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > > index 61d28c743263..edcc419ba328 100644
> > > --- a/drivers/hv/vmbus_drv.c
> > > +++ b/drivers/hv/vmbus_drv.c
> > > @@ -1387,6 +1387,24 @@ static struct kmsg_dumper hv_kmsg_dumper = {
> > >  	.dump = hv_kmsg_dump,
> > >  };
> > > 
> > > +static void hv_kmsg_dump_register(void)
> > > +{
> > > +	int ret;
> > > +
> > > +	hv_panic_page = (void *)hv_alloc_hyperv_zeroed_page();
> 
> I know you just copy/pasted the original code, but one other thing.
> 
> Doesn't it already return void *?
> arch/x86/include/asm/mshyperv.h:void *hv_alloc_hyperv_zeroed_page(void);

Good catch.

I have amended this patch and applied it to hyperv-next.

Wei.