Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp872192pxu; Wed, 2 Dec 2020 05:43:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhdx7rrjoAMY+DRu2QKPGuGYEuEbUTkbSIWJDBzCpHenInsh9XCTo4y0RuR470uUSuXwEU X-Received: by 2002:a17:906:8058:: with SMTP id x24mr1101675ejw.262.1606916626265; Wed, 02 Dec 2020 05:43:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606916626; cv=none; d=google.com; s=arc-20160816; b=T2KkXT4aZkQJeBZa2dq8AwSDyp1DhXGwo/xhgbbaV3O8bYIddx75VTu+ktOnbZo33d 431sgN2RjtUBu2qgQxcGE304g9kX9LurRFaZ4Hv81ga2b3Z5tEYPOSGpzRSxKnmNDbwU ae9ccb8Y1J9xf4fN5wA7CvZ8k0386ER0zMHBnEV9aJ4KRUkKEpbxWBP2Ep7eUSPTl2h5 j1NEbDqqN0nn5VqgSluTNEpN3Jevvam19rj2ygb73+yRNA+dvhwo3Utq/V4DK+WWP336 vseTqyDsMJ3y3mOG5H0Z01vLO1u7REhG3QT+tw/aBILTziAYm5AUrJ6CG0tgyzGNlQy4 lUEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=KlaqU66clYq3IUh7WtiaDVFc6rJgSqC/O5tmg+XqKmA=; b=nCyYi+ZNXTBy24ZJ26lEtc9vtsqYpdS8vmYxd1yr1L3awz7J0HuegAuFwUuLNOULQh V4QZfcJzPBa+qXWTir0i27cxcs8fimGW4gfSFbYK21bEjIA+ITVui59Z30A3TGdBvt7O mDX8F6nuixBt+V76aUlBQYVidkYKoXI9nisLkDo1VY8P8k6AsicDbN13oul6jQ4ER5yf tUWM33q2QPJuDif4PP9dsH0nqWQkS+3+v9MLs40X4TY1VT6UnrPNvVqyt8ePqQv8T+hX B/bYlU7xfitWQWs0KrFIxIcbguUjREZGU7aF+08oZT+a2lu2fCsjoqVhBEJvOv3Qt3Pb Brpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g12si919043eje.114.2020.12.02.05.43.23; Wed, 02 Dec 2020 05:43:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730174AbgLBNk2 (ORCPT + 99 others); Wed, 2 Dec 2020 08:40:28 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:45643 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727927AbgLBNk1 (ORCPT ); Wed, 2 Dec 2020 08:40:27 -0500 Received: from orion.localdomain ([77.7.48.174]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N64FC-1k8zv90JuS-016L9F; Wed, 02 Dec 2020 14:37:55 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org Subject: [PATCH v2] gpio: just plain warning when nonexisting gpio requested Date: Wed, 2 Dec 2020 14:37:54 +0100 Message-Id: <20201202133754.32045-1-info@metux.net> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K1:x509up239nMwUVSsvhFUtmNN65DNpopoJqJa79l9iIluvPMt7mE O8tNgzo6nCm7380ByRyvDalQu2XmVYYgV3WjLbn6SLEk7DyBH6v0j7ZOMtodXI43bzCh0XQ 0iWNTu/+M3a5CJ5u0y8nsO4gpGaMXqat6Tn0VXr6+nBwD0+MkOvJbDtBRu18+xWvccmvTs1 4ymIJsDS8ii7UwhjQYmtQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:tXWjYQRg/tM=:V2T8r2rk7sbhOVtBqb7/gN sQJf5ELXMjzzvsFV55QvSgzNYM4fYcyE49NUFavA8QfRAHCU3MHYEklZxIHM0FUz55RmytM3Y BMAv7oj+Ls3mQXk6NnO9qdaR2+sdSwrN205NYzAU7b7fzyXHCYQg6Lrxc93D3UO8h4BGgfin4 9dM9rhBFfOXT5uXQ7qvwi4SmJCecF7uQNrvuIPGBuH3oZRPKJkdnUYTpq77PSHQahRUEVZJ8j UFfZQq5t70Rt+3S2/3QNA2yNdGRatY7KyR8jFOw0Pnkqd0rvaQmds9w0OoZFNFTByy2JhtS0g 7l7Ap7myX2s6abYoSRvvxJ5k0EmoflwjkOUXqCvUo5HQ8eKADBkdrAmxoLzLJ2z4gq2s3pglW f321KB1gtnYS9/npsLJLicuJcIE4/XQFiCZoZFwd8mdaTAn4yKY8Kf5dk2TIH Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Enrico Weigelt When trying to export an nonexisting gpio ID, the kernel prints out a big warning w/ stacktrace, sounding like a huge problem. In fact it's a pretty normal situation, like file or device not found. So, just print a more relaxed warning instead. changes v2: drop defining pr_fmt() Signed-off-by: Enrico Weigelt --- drivers/gpio/gpiolib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 089ddcaa9bc6..6639e7b77d6c 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1,4 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 + #include #include #include @@ -119,7 +120,7 @@ struct gpio_desc *gpio_to_desc(unsigned gpio) spin_unlock_irqrestore(&gpio_lock, flags); if (!gpio_is_valid(gpio)) - WARN(1, "invalid GPIO %d\n", gpio); + pr_warn("invalid GPIO %d\n", gpio); return NULL; } -- 2.11.0