Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp935019pxu; Wed, 2 Dec 2020 07:06:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEWK0u6kJ5Slu/IWoSQm4Yxhmvo2XrFV63Vmsc/PhF6Mv+Gq0SicEG49PaIjF9F0iNNvh1 X-Received: by 2002:a17:906:d8a1:: with SMTP id qc1mr203933ejb.294.1606921579241; Wed, 02 Dec 2020 07:06:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606921579; cv=none; d=google.com; s=arc-20160816; b=gshTUCSX4Cc00KFYlgxpbQ32wVa+WtqRdeRqLYvQ9qB/9/NLjmXGXctiFTgp2BGxXA 7zTbWOrlZUhgcrlXLQlCHnj2blInd2Sk0JcToww3l/WS0jzb/t9U6x9LUzJ6ALZt6qdd PniheaW5PpFPWaSnTwZaBgllSf3Pv6m/9GRmWsE5o1tgmiQcwjXx79RAQbul4bOTeAAX GSztJdgfUsB23hgA+UHR9wfeM5Gag1bCuv7hfDcwBmSdp6L7ukcZEEGu3SGefGhNyBWn yMpzvOM2FfOD79O5rkrkFtRb1qshQ05ObincksWqMCDT56Exm7qvkracOQIcViQjlBt6 oxhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:dkim-signature:dkim-signature; bh=zKHBXpuw+WPRxYjKCr+NVoOy6HmLEmipUWxQdocXY44=; b=f8t5GacVX6oWIJo6tLk4i3OEwiswiHOXpfwJPzKPX7pStiZKm39INpozhR7FXWofLL bcoE2JmBfHgpEqvifYxtU3C+SnXqbOBb3L0VH0ccZQydkHfv6PlGQtM19hlswcN1QdHt sApjoamwmDZmbSXTiy9SMN7SWXSYruYiOZ+5lxegpDg31SmtCYnqntMKxmSmup2BEsIR J269SCJVV7kucVjDE9sZwJSMxijs+2Ox8BQxkx6mZkivm2xcyidsABEsTjp72+0mfpEh u6N9MeeQPD5EP3cibhwMSb9yYzYbJ/IGoMUykVHp8xu/oLNsrXhw0OpnpMQQ/ZoIBeOc iQCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm1 header.b=inplWYyf; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=Fq+VbBky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id of22si105442ejb.321.2020.12.02.07.05.54; Wed, 02 Dec 2020 07:06:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm1 header.b=inplWYyf; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=Fq+VbBky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730211AbgLBPD4 (ORCPT + 99 others); Wed, 2 Dec 2020 10:03:56 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:58737 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbgLBPDz (ORCPT ); Wed, 2 Dec 2020 10:03:55 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 4DF59580132; Wed, 2 Dec 2020 10:03:09 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 02 Dec 2020 10:03:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=zKHBXpuw+WPRxYjKCr+NVoOy6HmLEmi pUWxQdocXY44=; b=inplWYyfQJqds7vglOwm5zUoQr2WvvTwZ81yB/6SWEAfzt4 yyfNOxpkuC8Gho2V8At4KOUsKV3LESaha0MQQa5dEm/UcT8ailj9ZNY1kPCaOqaj Fh37aCFHPOB2pQLhVcqXD1X4d2oXJ7CXjuGzkIQ0Gwdta0ytwJhsWIh/HTxom0Bt gCC1QVNvKEpMU/OTL2tA5qQCoqZvePhEG3pcEiaJ3vNXM2Sa6tyQmH9sPDfSFHmp V68iVy14EvlkSFiaLVadcaCdfX1C7uyEpvqTCx9Qy6iu4WpY330rdErGufQInr6t +S58OJd4UF3qpt6GZ0d11EIikMwcf6BQjEDQTGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zKHBXp uw+WPRxYjKCr+NVoOy6HmLEmipUWxQdocXY44=; b=Fq+VbBkybpikgWgp2qOWLZ gYejKwOvXLsdF7H0+DdyZb2/oH2bgEK+1ZzGR7Tb+GQgL0jsCi7+t7pjRP2pJlPe ooCgBttACOiSMU/fU7NiM5Ou55eQWXS2rDK+4ygx7JWnsCEWdaL2EQzSA5l72hms tbfyX6Mmu+WiZhlQz+ERKFiK9vqoMEt1sMXlx3aS3OzLyG2B3BDfP5v/AKLystW6 Ppr1jmNbSzq3Qpra9VEfIT/xRZ0vGIvnAzc5WCbc6v0OnTzRLJRdN+a195mWDCD9 sGt0hwaRdNhj2jdUDF9RzRsknSrL4fTk0QgJfk0LbH/qaAIYHiVunifURA/zVhRQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhephefhfeekgfekudevheffheeihedujeefjeevjeefudfgfeeutdeuvdeh hfevueffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7CD5CE00D4; Wed, 2 Dec 2020 10:03:04 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-622-g4a97c0b-fm-20201115.001-g4a97c0b3 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20201202063612.21241-1-troy_lee@aspeedtech.com> <20201202063612.21241-3-troy_lee@aspeedtech.com> Date: Thu, 03 Dec 2020 01:32:44 +1030 From: "Andrew Jeffery" To: "Troy Lee" , "Joel Stanley" Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "Tony Luck" , "Ryan Chen" , "James Morse" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" , "Robert Richter" , "leetroy@gmail.com" , "Rob Herring" , "Borislav Petkov" , "Stefan M Schaeckeler" , "Mauro Carvalho Chehab" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list:EDAC-CORE" Subject: Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Dec 2020, at 19:11, Troy Lee wrote: > Hi Joel, > > Thanks for the suggestion, I'll fix the review and create an new patch > against > latest Linux branch. Those exported function will be referenced in > other driver yet > to be upstream, so should I move those exported functions out of this > patch? > Yes, let's leave the exports out of this patch, and add them in when you send the patch that depends on them. Andrew