Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp972147pxu; Wed, 2 Dec 2020 07:57:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJwK1udZEuoqBDYCsbooPwnJCO10SLo0T7W3YZ/N70pCr1Fw9opFVnmsXh7gNNMSiBrDGbrq X-Received: by 2002:aa7:dac5:: with SMTP id x5mr565087eds.198.1606924644142; Wed, 02 Dec 2020 07:57:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606924644; cv=none; d=google.com; s=arc-20160816; b=dAVkiRA45Swo27Cukfs33I0CXdDpeHx4UGo/hC8oTsOCx9Ys7KK5En+7ch5nPG1J1I HjAs/szSj2hd4/5YbowHAn1KBog6yUz1u+LKRPzOUa99sSqSR6ZLbVzzc5b10hFIKkxO kpilyFuKhNpAl2bw0ioFAx76g50RSnR0/wmuhB+idASU47BKKgxRx3DtaLBgSYPpNjw4 Gr7fTUlh6Oc39cSbzW7fv3IJZO2Rxs4Q53DZBy0HeZjb2dOkG0cLrys6drtGeP6jJmRU cR1vu0G6C2KG5qqqD8z0fpK2VfMyJ9ok8ODatqGKUSqs5so491lceClMuFhlR4qP2NR2 rkRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=FMiWr7lDMrfjommOfHGDSEgUjLGk5ea1r00CAw+vU2c=; b=0/sqIhF8I74tzbrF3U5jDXqz0YS1ydiaY3CJ2KCY2Q8wSd5NjsovgoxRpof83FUO/v DbrMHSCdgP9JlkQTMLBHPXOnEhn1Qd8ZycCwlWq9rlmnM6fMFHmYAh7QQ0yf6Cs/My7M W26uz/DDnT5eRMdc5G7zoe5IVhF4VsDRLJY1v497uYp3yo3PRn6MRfHK5Bql6pQNDIC7 2bHbdPPfFVGZoM2LNaqy+zG/+pFJYRUYAsS3/Pz7VBOsK2SOUUnezUtWp5Reaov5twAh fSHCPbIT+olqzgTT0vUjJ2OPIVV1vGE7odsaypWoEMYTegXTtrNouTabiWThVHlyy+7G 9KAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si173673ejw.244.2020.12.02.07.57.00; Wed, 02 Dec 2020 07:57:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387931AbgLBPxV (ORCPT + 99 others); Wed, 2 Dec 2020 10:53:21 -0500 Received: from mga09.intel.com ([134.134.136.24]:47180 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727725AbgLBPxV (ORCPT ); Wed, 2 Dec 2020 10:53:21 -0500 IronPort-SDR: VtiqZLQpjctfMv0QN5tUmpeOKHBVxPKRFwWa9jnts1DB9DSuXha3brjGZ6JqNpip2fQIza9GPV eOSnuzbEa/wQ== X-IronPort-AV: E=McAfee;i="6000,8403,9823"; a="173194809" X-IronPort-AV: E=Sophos;i="5.78,387,1599548400"; d="scan'208";a="173194809" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 07:51:40 -0800 IronPort-SDR: 1saECTZ06J0Pd5CoYIuPgi5eATW5aWi8+qDgwlYZOHd3VIFz1dSC0xiV7ioAnAQHfGrLS1G/NE /4ISzNp5WTyA== X-IronPort-AV: E=Sophos;i="5.78,387,1599548400"; d="scan'208";a="539740422" Received: from ajrodr4-mobl1.amr.corp.intel.com (HELO [10.213.167.252]) ([10.213.167.252]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 07:51:38 -0800 Subject: Re: [PATCH] ASoC: intel: sof_rt5682: Add support for tgl_rt1011_rt5682 To: Brent Lu , alsa-devel@alsa-project.org Cc: Guennadi Liakhovetski , Cezary Rojewski , Dharageswari R , Kuninori Morimoto , Kai Vehmanen , linux-kernel@vger.kernel.org, Takashi Iwai , Jie Yang , Liam Girdwood , Ben Zhang , Mark Brown , Sathyanarayana Nujella , Fred Oh , Naveen Manohar , Libin Yang , Bard Liao , Rander Wang , Yong Zhi References: <20201202015826.7678-1-brent.lu@intel.com> From: Pierre-Louis Bossart Message-ID: <9d3d76fd-869c-ec20-0fa0-a0da88e32502@linux.intel.com> Date: Wed, 2 Dec 2020 09:18:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201202015826.7678-1-brent.lu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +struct { > + unsigned int tx; > + unsigned int rx; > +} rt1011_tdm_mask[] = { > + {.tx = 0x4, .rx = 0x1}, > + {.tx = 0x8, .rx = 0x2}, > +}; as noted in the GitHub review this should be static and possibly const.