Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 2 Dec 2020 18:11:33 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Lubomir Rintel <lkundrak@v3.sk>,
        Mark Brown <broonie@kernel.org>, allen <allen.chen@ite.com.tw>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Heiko Stuebner <heiko@sntech.de>,
        Josua Mayer <josua.mayer@jm0.eu>,
        Andreas Kemnade <andreas@kemnade.info>,
        Arnd Bergmann <arnd@arndb.de>, Daniel Palmer <daniel@0x0f.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v4 3/7] mfd: Add base driver for Netronix embedded
 controller
Message-ID: <X8fKxdIqCbHtx38Q@latitude>
References: <20201122222739.1455132-1-j.neuschaefer@gmx.net>
 <20201122222739.1455132-4-j.neuschaefer@gmx.net>
 <20201202130520.GL4801@dell>
 <X8ed7stMOGhnZ18T@latitude>
 <20201202150943.GN4801@dell>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CjPGjgSPWBKyBoQi"
Content-Disposition: inline
In-Reply-To: <20201202150943.GN4801@dell>
Precedence: bulk


--CjPGjgSPWBKyBoQi
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 02, 2020 at 03:09:43PM +0000, Lee Jones wrote:
> On Wed, 02 Dec 2020, Jonathan Neusch=C3=A4fer wrote:
>=20
> > On Wed, Dec 02, 2020 at 01:05:20PM +0000, Lee Jones wrote:
> > > On Sun, 22 Nov 2020, Jonathan Neusch=C3=A4fer wrote:
> > [...]
> > > > +	/* Bail out if we encounter an unknown firmware version */
> > > > +	switch (version) {
> > > > +	case 0xd726: /* found in Kobo Aura */
> > >=20
> > > No magic numbers.
> > >=20
> > > Please submit a subsequent patch to define this.
> >=20
> > Will do.
> >=20
> > But I don't think I'll be able to give it a more meaningful name than
> > NTXEC_VERSION_D726. I don't have a good overview of which versions
> > appear in which devices. "0xd726 found in Kobo Aura" only means that;
> > I don't know if it's the only version used in the Kobo Aura, and I don't
> > know if the Kobo Aura is the only device where it is used.
>=20
> Defines are not set in stone.
>=20
> They can evolve over time as more is known.
>=20
> NTXEC_KOBO_AURA would be fine for now.

Alright.


Thanks,
Jonathan Neusch=C3=A4fer

--CjPGjgSPWBKyBoQi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl/HyrUACgkQCDBEmo7z
X9ujoRAAiSfqDRe/Gtnw9hmQ5U6LeACNBPYHEExRWA9+KkwWBO6oVYGD06v1QLp/
7M9dBhcudCM7OXobAwKgZWlnDOTgTct1TNehCOzq7ZyCUbz1oe5+QN+KY98RQNgK
2ZxEIJFrCoyWSBrPRH6qAiFDb3E28xIYJmZmX/EoHYOiVUfeo9DaaiLTZrIOapRg
jjUZ5SDM99aB7z2TGjdjpSyRee+t0jSNgvrdb+z+oJ0ODiKJmWYVvCtHWtiZ+30J
h5z31aKESIm2BaAxM6Xdv2m4OvWURx61gVCx51KVELcwGDtza2nz9osBrcLWqiWm
OVBszstZwniWDNHqEGx5D4jnYdzLE6YG2ll5O9E3fPzrx3Vr28xmabea8bLiw6gF
v1jDpZIy/Vx9vxz5+baXfPFLHBqLqNmsXHW0r4EAcNDyBy3B97Qq1R64nCBPKt7c
3wV+5ja9hykCjQLXAoH9TuATnTP7d5Ya4+njW6KP2p9p6PocSrG9mkKHlgucZGNZ
ZYGOndbFNw16IOyHhu5Vr8LnvND7qZiYbP1i16L3CVduulbnJGVdWF3v1iH8IHHD
yb67MJGHa+qDRI1AAsRt0KgM8Pd9sRmrqIxFDlOp0LOscg45FifdV8k5WjQ79hkT
s5oiVIYAZ0bHyKLggR/Q3yvBFG695uXZucUUZMKj9WyBTYZOsfQ=
=OnND
-----END PGP SIGNATURE-----

--CjPGjgSPWBKyBoQi--