Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1054249pxu; Wed, 2 Dec 2020 09:52:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyc/dD6sIzN+BujpbmPTAX4E7NnsUXzYeiNxNNWTLpVA1X15MRwUYKUbOmh+G8p06jxtB1q X-Received: by 2002:a17:906:af83:: with SMTP id mj3mr863138ejb.243.1606931529240; Wed, 02 Dec 2020 09:52:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606931529; cv=none; d=google.com; s=arc-20160816; b=fHe1XgycswRdBi5n/QV7SPccwu+UIIXI+8k1xwtwWmmtYe5+gg7sBGqdi5+CDmabpS 4hXjfMr8vSFk3XiOW2fIQ731av5ys4QomNyP6nCJ5nAzjivrRvKu+DKxagcUrFw3GWgd eHvJSqUvWEwi9EIQ95Lu9do0HPG7xHWljXpnFLgtKiJzk3LdK39RcfqPEtB1NZpIZBSD oi9Bg1fVIyIrCC3zpOHgoWDNDlbrBlxJuKgxxjCYQpJ4Ndk4D5uCMRU5WG9VkEZfBUv6 MntizHIlKVImZ1u7bPC0zcAk0G/4dcgIV6wwN5cwNmxw1ofsHhfgq8pFGL3L5eCVyxBB ozoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wTQSvCRTnofRmGZEVImfL82YoCsJupVMjaNXuGnw7P8=; b=sS3eca3pUlNk4G1mqMjCzu9yXbnR4nuKoMxOZtlvYt9L/iExv2a5Sz8pyBUDbnspMV ZN5/S7HToXbaplAejFMaBBDCr/0mtoxOAIo5CEGkdbqyZ8mcAymCdU6yi49Ksz9Q2g9b utCi5somrzT4BF4tL6PYAl1cfwCrevmgWip3hF0sBcdWHJ4YaXk7mDACqHsEwe37pzgI tGFxglIEWLmFHf33PwGtPuHLrZISSDAVzK/l11o1ecmp1HJlDA4gZ3FW90RHjJmhkEFD 3yi33mL5x/IberKlLXltpnpzhIvAMFXdZ8ThQwaBp73MvjGeRfuOayxKowf7UttNLupG p7SA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si412803edq.549.2020.12.02.09.51.45; Wed, 02 Dec 2020 09:52:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389310AbgLBRuE (ORCPT + 99 others); Wed, 2 Dec 2020 12:50:04 -0500 Received: from mailoutvs25.siol.net ([185.57.226.216]:57676 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387863AbgLBRuE (ORCPT ); Wed, 2 Dec 2020 12:50:04 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id C89AA521022; Wed, 2 Dec 2020 18:49:21 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id CNHRojKcScea; Wed, 2 Dec 2020 18:49:21 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 554F752100D; Wed, 2 Dec 2020 18:49:21 +0100 (CET) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id C3319521022; Wed, 2 Dec 2020 18:49:20 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Chen-Yu Tsai , Andre Przywara Cc: Icenowy Zheng , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Linus Walleij , Rob Herring , Yangtao Li , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Andre Przywara Subject: Re: [PATCH 3/8] pinctrl: sunxi: Add support for the Allwinner H616-R pin controller Date: Wed, 02 Dec 2020 18:55:32 +0100 Message-ID: <47263727.bh6W02dunB@kista> In-Reply-To: <20201202135409.13683-4-andre.przywara@arm.com> References: <20201202135409.13683-1-andre.przywara@arm.com> <20201202135409.13683-4-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne sreda, 02. december 2020 ob 14:54:04 CET je Andre Przywara napisal(a): > There are only two pins left now, used to connect to the PMIC via I2C. > > Signed-off-by: Andre Przywara > --- > drivers/pinctrl/sunxi/Kconfig | 5 ++ > drivers/pinctrl/sunxi/Makefile | 1 + > drivers/pinctrl/sunxi/pinctrl-sun50i-h616-r.c | 58 +++++++++++++++++++ > 3 files changed, 64 insertions(+) > create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun50i-h616-r.c > > diff --git a/drivers/pinctrl/sunxi/Kconfig b/drivers/pinctrl/sunxi/Kconfig > index 73e88ce71a48..33751a6a0757 100644 > --- a/drivers/pinctrl/sunxi/Kconfig > +++ b/drivers/pinctrl/sunxi/Kconfig > @@ -124,4 +124,9 @@ config PINCTRL_SUN50I_H616 > default ARM64 && ARCH_SUNXI > select PINCTRL_SUNXI > > +config PINCTRL_SUN50I_H616_R > + bool "Support for the Allwinner H616 R-PIO" > + default ARM64 && ARCH_SUNXI > + select PINCTRL_SUNXI > + > endif > diff --git a/drivers/pinctrl/sunxi/Makefile b/drivers/pinctrl/sunxi/Makefile > index 5359327a3c8f..d3440c42b9d6 100644 > --- a/drivers/pinctrl/sunxi/Makefile > +++ b/drivers/pinctrl/sunxi/Makefile > @@ -24,5 +24,6 @@ obj-$(CONFIG_PINCTRL_SUN50I_H5) += pinctrl-sun50i-h5.o > obj-$(CONFIG_PINCTRL_SUN50I_H6) += pinctrl-sun50i-h6.o > obj-$(CONFIG_PINCTRL_SUN50I_H6_R) += pinctrl-sun50i-h6-r.o > obj-$(CONFIG_PINCTRL_SUN50I_H616) += pinctrl-sun50i-h616.o > +obj-$(CONFIG_PINCTRL_SUN50I_H616_R) += pinctrl-sun50i-h616-r.o > obj-$(CONFIG_PINCTRL_SUN9I_A80) += pinctrl-sun9i-a80.o > obj-$(CONFIG_PINCTRL_SUN9I_A80_R) += pinctrl-sun9i-a80-r.o > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun50i-h616-r.c b/drivers/pinctrl/ sunxi/pinctrl-sun50i-h616-r.c > new file mode 100644 > index 000000000000..eb76c009bf24 > --- /dev/null > +++ b/drivers/pinctrl/sunxi/pinctrl-sun50i-h616-r.c > @@ -0,0 +1,58 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Allwinner H616 R_PIO pin controller driver > + * > + * Copyright (C) 2020 Arm Ltd. > + * Based on former work, which is: > + * Copyright (C) 2017 Icenowy Zheng > + * Copyright (C) 2014 Boris Brezillon > + * Boris Brezillon > + * Copyright (C) 2014 Maxime Ripard > + * Maxime Ripard > + */ I'm not sure if it makes sense to reference so many previous work for so simple driver... Anyway: Reviewed-by: Jernej Skrabec Best regards, Jernej > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "pinctrl-sunxi.h" > + > +static const struct sunxi_desc_pin sun50i_h616_r_pins[] = { > + SUNXI_PIN(SUNXI_PINCTRL_PIN(L, 0), > + SUNXI_FUNCTION(0x0, "gpio_in"), > + SUNXI_FUNCTION(0x1, "gpio_out"), > + SUNXI_FUNCTION(0x3, "s_i2c")), /* SCK */ > + SUNXI_PIN(SUNXI_PINCTRL_PIN(L, 1), > + SUNXI_FUNCTION(0x0, "gpio_in"), > + SUNXI_FUNCTION(0x1, "gpio_out"), > + SUNXI_FUNCTION(0x3, "s_i2c")), /* SDA */ > +}; > + > +static const struct sunxi_pinctrl_desc sun50i_h616_r_pinctrl_data = { > + .pins = sun50i_h616_r_pins, > + .npins = ARRAY_SIZE(sun50i_h616_r_pins), > + .pin_base = PL_BASE, > +}; > + > +static int sun50i_h616_r_pinctrl_probe(struct platform_device *pdev) > +{ > + return sunxi_pinctrl_init(pdev, > + &sun50i_h616_r_pinctrl_data); > +} > + > +static const struct of_device_id sun50i_h616_r_pinctrl_match[] = { > + { .compatible = "allwinner,sun50i-h616-r-pinctrl", }, > + {} > +}; > + > +static struct platform_driver sun50i_h616_r_pinctrl_driver = { > + .probe = sun50i_h616_r_pinctrl_probe, > + .driver = { > + .name = "sun50i-h616-r-pinctrl", > + .of_match_table = sun50i_h616_r_pinctrl_match, > + }, > +}; > +builtin_platform_driver(sun50i_h616_r_pinctrl_driver); > -- > 2.17.5 > >