Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1057914pxu;
        Wed, 2 Dec 2020 09:58:02 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxu7BOkPjuLiFi+NoRM8UU24/kRbswmQK4crYubePsT7EekAATBbYjMXHIWMogkNpoqdHvN
X-Received: by 2002:a50:dac9:: with SMTP id s9mr1099237edj.75.1606931882511;
        Wed, 02 Dec 2020 09:58:02 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1606931882; cv=none;
        d=google.com; s=arc-20160816;
        b=006RbH0KVty7H4fIBnwPPAPhmtDi8xx/Kpp4WvNlGR4pvOKirp3pvL0iVuCqVwciho
         pAm5JmuMeHielKISrg6pqNdhBaqoOl6YLBp94JZX6W+brjyE+OO2DLukWHuIPWCexFF8
         DeGZL8pD7HasK5KGQOtZ7ioIGoQtWn5+Czzm/UFY1aZnuJyXafAtNofCtTxBzvKbtymI
         KAfqsVWPg0unT/mA/oE0kOI0sI4QsRmpulUb9O90VYUoIBgZqKkt/pS1jAVzqRfptUDk
         1gFjJzZf8nHKkWlIQp4NbV+DBa12+nyOq3Cgnkw+EXXqIzC1dHOZYQUwsj5VE+ZEzGbm
         Muzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature
         :date;
        bh=Yad3krA+a2unFEH87i3zNQ7Zbm64KX9EoL3OGfrfhZs=;
        b=EPWL5EqmBNBepPpHaTRnDYaUSpw8FTXk+OdOau7dxZtIzB5C708z0GZRrDO+liuxug
         mcUxnvm3EAZdc9YNlZYG+F3gi08npPzgY7GHTMso6a2d2s4nciUi+k61YtX+RcM29f8c
         4KCuEu7CwDnjiEaeCe23f/+cbhjE5ZwFEb5iQy2JZi959ciZfCEeQyTzdw93ixyZbluR
         s8dQaACXkSl1GBY1MU0WyYF9VTsGTKzfRIMugtlCycCVng3j8cHrmVB22rvPGjtRvFo9
         p5jboCgRNglktJpebIfKAGC6zHbP2FsPqXcqm8d2s0Ct2H1Td2UjBo9ujaDu4+utzNHp
         OkLw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=qObwmVBC;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id y15si407153ejp.228.2020.12.02.09.57.39;
        Wed, 02 Dec 2020 09:58:02 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=qObwmVBC;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728896AbgLBRyD (ORCPT <rfc822;epontan@gmail.com> + 99 others);
        Wed, 2 Dec 2020 12:54:03 -0500
Received: from mail.kernel.org ([198.145.29.99]:51396 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728444AbgLBRyD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 2 Dec 2020 12:54:03 -0500
Date:   Wed, 2 Dec 2020 09:53:20 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1606931602;
        bh=cwmdyU6NKbjjsZCsVAPbwEXDkqGwHYdB1/A1gSP4eBc=;
        h=From:To:Cc:Subject:In-Reply-To:References:From;
        b=qObwmVBCHZTv4W5y7s2t4hic7HjPi2IpVrV216YDrrDLSMaGPVuEdq5f9WpODDPYU
         TZ21LG5cRUfs/xnfv5lSDqQjYXmiso5RUZZdirNLUnQZcx07tZYgDfiQi/Nu3u0MEE
         75r73L8HSZ+TpQuWyixqxifNSErwqVBVDof0lh20=
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jarod Wilson <jarod@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Ivan Vecera <ivecera@redhat.com>,
        Jay Vosburgh <j.vosburgh@gmail.com>,
        Veaceslav Falico <vfalico@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        "David S. Miller" <davem@davemloft.net>,
        Thomas Davis <tadavis@lbl.gov>, netdev@vger.kernel.org
Subject: Re: [PATCH net v2] bonding: fix feature flag setting at init time
Message-ID: <20201202095320.7768b5b3@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
In-Reply-To: <20201202173053.13800-1-jarod@redhat.com>
References: <20201123031716.6179-1-jarod@redhat.com>
        <20201202173053.13800-1-jarod@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed,  2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote:
> +	if (bond->dev->reg_state != NETREG_REGISTERED)
> +		goto noreg;
> +
>  	if (newval->value == BOND_MODE_ACTIVEBACKUP)
>  		bond->dev->wanted_features |= BOND_XFRM_FEATURES;
>  	else
>  		bond->dev->wanted_features &= ~BOND_XFRM_FEATURES;
> -	netdev_change_features(bond->dev);
> +	netdev_update_features(bond->dev);
> +noreg:

Why the goto?