Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sonal Santan <sonals@xilinx.com>
To:     Moritz Fischer <mdf@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        Max Zhen <maxz@xilinx.com>, Lizhi Hou <lizhih@xilinx.com>,
        Michal Simek <michals@xilinx.com>,
        Stefano Stabellini <stefanos@xilinx.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files
Thread-Topic: [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files
Thread-Index: AQHWxeLgPKk468uu20KtHlzY5ljvuKnhqLiAgAKC/kA=
Date:   Wed, 2 Dec 2020 18:57:11 +0000
Message-ID: <BY5PR02MB6260A727613D2D8A447B1D26BBF30@BY5PR02MB6260.namprd02.prod.outlook.com>
References: <20201129000040.24777-1-sonals@xilinx.com>
 <20201129000040.24777-3-sonals@xilinx.com> <X8XGI7yRAX+xAeqQ@archbook>
In-Reply-To: <X8XGI7yRAX+xAeqQ@archbook>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 49454620-7e40-49f6-e853-08d896f4138c
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2020 18:57:11.6213
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: S/rMA3iVkhjl45AlcVDT0lHdJKqJs7I9Vy4GdrbNafsDEPyMitSMjWMboWSYwZ0TpKL2OnwlCE4JZzxHadCI9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB4839
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Moritz,

> -----Original Message-----
> From: Moritz Fischer <mdf@kernel.org>
> Sent: Monday, November 30, 2020 8:27 PM
> To: Sonal Santan <sonals@xilinx.com>
> Cc: linux-kernel@vger.kernel.org; linux-fpga@vger.kernel.org; Max Zhen
> <maxz@xilinx.com>; Lizhi Hou <lizhih@xilinx.com>; Michal Simek
> <michals@xilinx.com>; Stefano Stabellini <stefanos@xilinx.com>;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files
>=20
> Hi Sonal,
>=20
> On Sat, Nov 28, 2020 at 04:00:34PM -0800, Sonal Santan wrote:
> > From: Sonal Santan <sonal.santan@xilinx.com>
> >
> > Add XRT UAPI header files which describe flash layout, XRT mailbox
> > protocol, xclBin/axlf FPGA image container format and XRT management
> > physical function driver ioctl interfaces.
> >
> > flash_xrt_data.h:
> > Layout used by XRT to store private data on flash.
> >
> > mailbox_proto.h:
> > Mailbox opcodes and high level data structures representing various
> > kinds of information like sensors, clock, etc.
> >
> > mailbox_transport.h:
> > Transport protocol used by mailbox.
> >
> > xclbin.h:
> > Container format used to store compiled FPGA image which includes
> > bitstream and metadata.
>=20
> Can these headers be introduced together with the code that uses them as
> logical change?
>=20
> I haven't looked too closely, but it helps reviewing if you can break it =
into
> smaller pieces that can stand by themselves.
>=20

These UAPI header files are used by multiple source files hence I wanted to=
 get=20
these reviewed separately. However if this is getting in the way, in the ne=
xt=20
version of the patch series I would look into arranging the files different=
ly.

You can browse the changes here as well--
https://github.com/Xilinx/linux-xoclv2/tree/xrtv2-A

Thanks,
-Sonal

> Thanks,
> Moritz