Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Uyfi/dOH0U1JHRGkMft5Ya+cBYlQkUejbFFrVHgFGJMlGvAr2QLu8ya7cDjP7uvkQvMV4Cwn+h
 8/QV+TdWyGkw==
IronPort-SDR: tJqPkaYET2VK+XwPUQMAf0LvzhTpG/zn5zuMDG/l5JrlZ6Dsks/sl7KlHuqlX4123SiFvvVUCq
 3JlIblxC0LlQ==
Date:   Wed, 2 Dec 2020 11:28:28 -0800
From:   Andi Kleen <ak@linux.intel.com>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ian Rogers <irogers@google.com>
Subject: Re: [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event
Message-ID: <20201202192828.GG1363814@tassilo.jf.intel.com>
References: <20201202150205.35750-1-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201202150205.35750-1-namhyung@kernel.org>
Precedence: bulk

> +	prev_cgrp = task_css_check(prev, perf_event_cgrp_id, 1)->cgroup;
> +	next_cgrp = task_css_check(next, perf_event_cgrp_id, 1)->cgroup;
> +
> +	if (prev_cgrp != next_cgrp)
> +		perf_sw_event_sched(PERF_COUNT_SW_CGROUP_SWITCHES, 1, 0);

Seems to be the perf cgroup only, not all cgroups.
That's a big difference and needs to be documented properly.

Probably would make sense to have two events for both, one for 
all cgroups and one for perf only.


-Andi