Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Andrew Lunn <andrew@lunn.ch>, jim.cromie@gmail.com,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        =?utf-8?Q?Bart=C5=82omiej_=C5=BBolni?= =?utf-8?Q?erkiewicz?= 
        <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet
 Adapter Driver
Date:   Wed, 02 Dec 2020 21:07:11 +0100
In-Reply-To: <20201202091852.69a02069@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
        (Jakub Kicinski's message of "Wed, 2 Dec 2020 09:18:52 -0800")
Message-ID: <dleftjsg8oc6q8.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20201202091852.69a02069@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
        <CGME20201202200727eucas1p18311ed19904e8a0c7b8c28cde87f155b@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-12-02 =C5=9Bro 09:18>, when Jakub Kicinski wrote:
> On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote:
>> >> +	status =3D netif_rx(skb);=20=20
>> >
>> > If I'm reading things right this is in process context, so netif_rx_ni=
()
>> >=20=20
>>=20
>> Is it? The stack looks as follows
>>=20
>>     ax88796c_skb_return()
>>     ax88796c_rx_fixup()
>>     ax88796c_receive()
>>     ax88796c_process_isr()
>>     ax88796c_work()
>>=20
>> and ax88796c_work() is a scheduled in the system_wq.
>
> Are you asking if work queue gets run in process context? It does.
>

Thanks. Changed.

>> >> +	if (status !=3D NET_RX_SUCCESS)
>> >> +		netif_info(ax_local, rx_err, ndev,
>> >> +			   "netif_rx status %d\n", status);=20=20
>> >
>> > Again, it's inadvisable to put per packet prints without any rate
>> > limiting in the data path.=20=20
>>=20
>> Even if limmited by the msglvl flag, which is off by default?
>
> I'd err on the side of caution, but up to you.
>

It isn't very common, but a few drivers do this.

Thank you.
=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl/H8+8ACgkQsK4enJil
gBAukAgAkQTRQG/TV08hxbnOYPNIUZApxZjUBbwMUF6alZVmWZFrc85AxK9+d6xs
gUPMlb86ylXmRX25dZ2dDCEoUgFOk+GrjLQbLyZTWl3dIIGiDvYJhf09P7qHuPD5
xbScoNohZrPAHxPlvciWexsAZLyboSunzdwiKGWGxpsWLrqz/Pb/x4DIUadv9QGA
siJUkTD0ZVKmO0kXjwBFVlqd1UDUpabwpafIgIr0SNMZT4shawKb8hFUtf3zPyZm
T5de0kdg01XISwJdq9ZnwaN3F4j4Pp2cQGfjPo4rRaztzOm+WytpdudbigmgbhpI
7PS3/QBVB46BH18tTQbHGLdAfBj0Kg==
=8UEH
-----END PGP SIGNATURE-----
--=-=-=--