Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp43126pxu; Wed, 2 Dec 2020 14:27:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWOl5Ycp9NIx4NceUYlohUV+drLWtyHC56qiNEmkdg78ree4J10F6WzPdsXv2VduVeO9/b X-Received: by 2002:a17:906:5c53:: with SMTP id c19mr1860358ejr.31.1606948077209; Wed, 02 Dec 2020 14:27:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606948077; cv=none; d=google.com; s=arc-20160816; b=vJ4JMBiDWQ9BdDgDxpUaxt4Kvolna10T53UHyxwRwkaeisnP0BgQFadSAEcV4q4OXh TG36nnC9PIQJaVAzvuAtKKqIRhJm/Mlz3qP6JiDqeLMsGRiLVt5K+UG7QYMW+z7vI52C ic6axZJ4CJ27d2oKI4DWJF5tgd5ZoGrsnPZ8kRpH871oLhPIU0+BXkthIkE3hZBgwx4T suJoKm3IbhJ26ihSlvCHkRW1gkCEUAd6nSmNJCjKrI5th37l8LvVPKgX7uqYXpEFzIcZ Njlom2TEP31B4szymtIZMr+52W2x4IwcGfAY3Z6v2TSBXIA3Vl6GXXOWTCOzZNTfq9ex Okmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=EJeEoDEeYHBeUS2YirOFrUkbP35JeO1CRiL+bErAeW0=; b=fiIXjQSlboswlqQoBF9XGACh+UeZaJkfPeZSYmL8DYsJ67dEC/3HLnbmw4nukGIyew dZiiQV55Jkff0voa6gPbvT0inRJbcFV3LDrl19ZYIVRguXLzaiAgr5lTDuZMdcigJ4s4 6K/RfUvRsoqweM5559BUkqmojGihsO5Hq2YFtX8meyibRafuTSw+72nniuVRuh3j4nZW T0X5HTM0zyRrBSatdELVVpwah7FLsTpJcxknKUz3/RhPA3tbCj/ZSgfFlskyP5pS3v3y mN9luHYZlvfaZZ659zkV3lNS4k2rV7sZRBF1nPZo1GXC+70pWtmQrjfHp+4wK1EcIVUe uXJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kBRld3J+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h2si76740edt.544.2020.12.02.14.27.33; Wed, 02 Dec 2020 14:27:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kBRld3J+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387427AbgLBWXN (ORCPT + 99 others); Wed, 2 Dec 2020 17:23:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbgLBWXN (ORCPT ); Wed, 2 Dec 2020 17:23:13 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D46C0617A6 for ; Wed, 2 Dec 2020 14:22:32 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id e25so662157wme.0 for ; Wed, 02 Dec 2020 14:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EJeEoDEeYHBeUS2YirOFrUkbP35JeO1CRiL+bErAeW0=; b=kBRld3J+mAXsKTi9w0PE358ZN0q7W4Yn1eDlhOle2/1Jzh/SOfwi2otG17uAn4srf8 bmqzlu6zF0GmKQLDBKfG3TSDwEBOkdok+B85dYrXw5PrkVOP2Z0u9LlctZIUXQOeeNr7 Fgpwa78Rb9JrpDGcxyPjTlZhPoK8mappbkXAidtMt9TkjNJ/tTmWYwyT74FTMZpVHceI tuNgTfXvy5lRfnJuXMVhPaa9eO0OjLnn4JWhpKiu3J1axZ+KAo4mxjrjRqDB1J52qpTg XT8EF3Sv9cFA84f+M5PV20JSyGpbJNZIW2GXTiPtExEzoFTRtvD9FNNelcecEMu+cFOF U91w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EJeEoDEeYHBeUS2YirOFrUkbP35JeO1CRiL+bErAeW0=; b=snfhPaOVaDeOQVsbGsbtLdVO3KxR22+GyZZc9BXvZ6BESsGO/0lhKXAkBtYexRnenu POTAgoMTHHwevbtxbihbM3V3mIKWGYX5o7WwfwX0YmqkxleLzN9mv74l6b2tdHdpr5cH hnPW0kgJh0/XyygZPfIWwqZmr5FycxYnHL+3ZisOxQnes4Xhu9iBIUeCgciAblRIBFfu kInaGw2ZFQ3LMmtxP7OGn/g/eP/bpT4bEcFnHq7PQFTwA9Z/IT61J6Xx4K+FcQc6YsLT eSU5y+OklQ8gm+8jtBnmXA2mYggtk4bhT8OcKvS+KvwmtCVT4CfTRJEdtm3jUV5c4IOt enXw== X-Gm-Message-State: AOAM533PJn6upgjrY1oLMW9lSS99CttBPPQtVm57jEXN3626CgRa3Hcb ZnmnHXbAfDEy207SKK6MebkwoA== X-Received: by 2002:a1c:3d86:: with SMTP id k128mr122654wma.66.1606947751390; Wed, 02 Dec 2020 14:22:31 -0800 (PST) Received: from mai.imgcgcw.net ([2a01:e34:ed2f:f020:1c7d:2d7a:9709:b9a2]) by smtp.gmail.com with ESMTPSA id s8sm63672wrn.33.2020.12.02.14.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 14:22:30 -0800 (PST) From: Daniel Lezcano To: daniel.lezcano@linaro.org Cc: Peter Kaestle , Hans de Goede , Mark Gross , platform-driver-x86@vger.kernel.org (open list:ACER ASPIRE ONE TEMPERATURE AND FAN DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/2] platform/x86/drivers/acerhdf: Use module_param_cb to set/get polling interval Date: Wed, 2 Dec 2020 23:22:11 +0100 Message-Id: <20201202222212.2313242-1-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The module parameter can be set by using ops to get and set the values. The change will allow to check the correctness of the interval value everytime it is changed instead of checking in the get_temp function. Signed-off-by: Daniel Lezcano --- drivers/platform/x86/acerhdf.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index 44b6bfbd32df..19fc8ff2225c 100644 --- a/drivers/platform/x86/acerhdf.c +++ b/drivers/platform/x86/acerhdf.c @@ -84,8 +84,6 @@ static struct platform_device *acerhdf_dev; module_param(kernelmode, uint, 0); MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off"); -module_param(interval, uint, 0600); -MODULE_PARM_DESC(interval, "Polling interval of temperature check"); module_param(fanon, uint, 0600); MODULE_PARM_DESC(fanon, "Turn the fan on above this temperature"); module_param(fanoff, uint, 0600); @@ -824,3 +822,11 @@ MODULE_ALIAS("dmi:*:*Acer*:pnExtensa*5420*:"); module_init(acerhdf_init); module_exit(acerhdf_exit); + +static const struct kernel_param_ops interval_ops = { + .set = param_set_uint, + .get = param_get_uint, +}; + +module_param_cb(interval, &interval_ops, &interval, 0600); +MODULE_PARM_DESC(interval, "Polling interval of temperature check"); -- 2.25.1