Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   03 Dec 2020 07:57:04 +0900
Message-ID: <87sg8nbz4o.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     mdurnev@gmail.com
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        mikhail_durnev@mentor.com
Subject: Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params
In-Reply-To: <1606907286-32104-1-git-send-email-mikhail_durnev@mentor.com>
References: <1606907286-32104-1-git-send-email-mikhail_durnev@mentor.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


Hi Mikhail

Thank you for your patch

> +			switch (rsnd_mod_id(src_mod)) {
> +			/*
> +			 * SRC0 can downsample 4, 6 and 8 channel audio up to 4 times.
> +			 * SRC1, SRC3 and SRC4 can downsample 4 channel audio
> +			 * up to 4 times.
> +			 * SRC1, SRC3 and SRC4 can downsample 6 and 8 channel audio
> +			 * no more than twice.
> +			 */
> +			case 1:
> +			case 3:
> +			case 4:
> +				if (channel > 4) {
> +					k_down = 2;
> +					break;
> +				}
> +			case 0:
> +				if (channel > 2)
> +					k_down = 4;
> +				break;
> +
> +			/* Other SRC units do not support more than 2 channels */
> +			default:
> +				if (channel > 2)
> +					return -EINVAL;
> +			}

I think you want to add "fallthrough" between case 1/3/4 and case 0 ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto