Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp70200pxu; Wed, 2 Dec 2020 15:19:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJxMiB6AlzZKVGRlk+hM5pb7s7FvObE3jODOpRIv199JZQlEHkf1o1ZvCE+AYYL3ufgKJr7D X-Received: by 2002:a17:906:27d1:: with SMTP id k17mr109140ejc.325.1606951197781; Wed, 02 Dec 2020 15:19:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606951197; cv=none; d=google.com; s=arc-20160816; b=R/S//gzKxq1aE1kmL1U6V7vzdeIEo3pCegzNGx94DWorMrVrwwyU1ZYI4jr2gwuj+W GETmSPjwRXdqvYNQXsXYZYSVXOg3HvlVT5wC4NFa/d5urXrKFrN/aJE1oLaHJipmZ5vS 7OR8VOKVeXjDcnkOWIO/Ak7667Zhr0sWHAmUw+bWvdmCkFwQmETkUPCae3ejfdG+rRTs LKSP+UUqTNM8V4wA89zhE5lg5skqBFriMZm1giBFLSKG4yhaykSyYqkMc+PHcHwnjKP7 vkQ7EeIyxOJx0XE4NHF9cct/z3N1LCBpUjRPZYZbGrr9p5RwCSemnXiopG8GGTL8xzte sycA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature :date; bh=2VxFXAGFQ6aP/khgynQupkLGUMny9c9db3YKlaZ3Vek=; b=EZlPfdB8ClmT+sBgoRP6MbZ/a8cYBwknyMCqOFASjPt+irtElXrHCN0bvFDmDkz0n3 0ZbDzYijCEaJ3pFUKFkRFePVgdHZKfKNsTgG25mnRMC3xldDzM+bR/QWhhoJtk3qMd0f uqu+x+nOA7Hy/DHZZaIgImTXG37JFBBff4qBOpXHX9l4+xfP46VM7HrAwYmnR5Cey+HS hvAK/EoTVH2ijjxgvuErWzZXsWAPtkgmNNQIfpMn4sRvnEKRQL5YA1/nZdt9/GPElZZg bhjJnhd0uRDesDCQnhuBOoGFpQSpuYsCkTLGq12XEJXsul9IZkwKkxl4FWJlBUYZqglN m42w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=oMYRn4E5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb10si165488edb.192.2020.12.02.15.19.34; Wed, 02 Dec 2020 15:19:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=oMYRn4E5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728364AbgLBXQi (ORCPT + 99 others); Wed, 2 Dec 2020 18:16:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:41760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbgLBXQi (ORCPT ); Wed, 2 Dec 2020 18:16:38 -0500 Date: Wed, 2 Dec 2020 15:15:56 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1606950957; bh=GIxDqD7uyqfqU0/Yhag9Aqk11nRK5ZDPMst72hACnKs=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=oMYRn4E54/4EJ2VENB7SaShDI/g86o6N/JdhUoTDOC5VmHLSl4punLBvaX5v7Euf9 9hGlahpHiYLijD46ROM026BV78121kP/7FN//sdG5r7agDQPf0a7aDgRq5lfOva2yA 2jCVgxmEf0igttv5F9MDtQMS8PwsLuwGfytOqjSI= From: Andrew Morton To: Qian Cai Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/swapfile: Do not sleep with a spin lock held Message-Id: <20201202151556.01077710acf79f6fd2ba8287@linux-foundation.org> In-Reply-To: <20201202151549.10350-1-qcai@redhat.com> References: <20201202151549.10350-1-qcai@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Dec 2020 10:15:49 -0500 Qian Cai wrote: > We can't call kvfree() with a spin lock held, so defer it. > Fixes: 873d7bcfd066 ("mm/swapfile.c: use kvzalloc for swap_info_struct allocatio n") Do you think it's worth a cc:stable? IOW, is this known to ever produce a warning? (If not, why did we need 873d7bcfd066??)