Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp82796pxu; Wed, 2 Dec 2020 15:44:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJxY7XwZioa9sI7VqarI9gxKmk1pSuC6/KEHABIqZBu6Z0R7Tvz9QREX3UMit6/cvAKlzMDk X-Received: by 2002:a05:6402:1a30:: with SMTP id be16mr454092edb.124.1606952666144; Wed, 02 Dec 2020 15:44:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606952666; cv=none; d=google.com; s=arc-20160816; b=nsPNqCxOEazDgztdV/OYGQUh2kZdVNdwAqN+fyI/6J8c1UwGD+0TAxLbkbQTw/hnXo p9TUN/FJ4fFtBaDkSSzVD6sIdoviZMRMOWQQMpcusIgqExSjvVgA93dgiFtlP04UiT4Q LDmgSFK47wZXZVTub58lgTXUOWHWOgj8vi6xAt5UG+t61qJJKBcBbpT4suPiuQ/LwAKT MySUesup/B8kICoeEXSZgKvDVATEAM3RuOmMhX+QKyJDet0RVKq9EyMivKl7AQI/9g+I sx/W5Wry2kdlnr11bsrlFrJbMdVBZU/0N7Prfi3R/fYyZKxX9lioxumIzQ1ORkOIgNRO 0zrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=iOY+ua6LPPG5oekDwz+/gTzCdxqCxzuOLrGK0RqQFSU=; b=Is5WMXaf4mWMZwQRS9dfc+qF3URILUY+SD058C2HyWV66MK53wuTdSBG7b6gGQNHyq zqB9HcIoJdOwxAGwdIJCerLbXhQMwWZ/Xo7RCjQpi9IYH4g0HIYRZ12bpybUA8j3F8HM WWQ3KAZj7Yyf3/c2tjtKDCXV5go5ywyXs4mX44txZK9LlqryovfLy3HRh4CcSHtC9jKU WKk9xmgCesl7Al0I9/rGk8vCqTX9wJo8lHw9GreWPw+ybbddWhBZrAxXDyZy9APQf05J POUUotWYRACYRfCaLMmf70qGI4LFaJf4zpE5QZ+1z59fk+/uf888RXtOzbh1hJTj1ZNp LV3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jJDRum2v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c26si201000edv.182.2020.12.02.15.44.03; Wed, 02 Dec 2020 15:44:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jJDRum2v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbgLBXki (ORCPT + 99 others); Wed, 2 Dec 2020 18:40:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60170 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbgLBXki (ORCPT ); Wed, 2 Dec 2020 18:40:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606952352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iOY+ua6LPPG5oekDwz+/gTzCdxqCxzuOLrGK0RqQFSU=; b=jJDRum2v5fRDSyQhLSX4KYlSXTUj9bdKCAi8/HPfPLb5LhMBhl8GalaIqjJB2m4kTKJPql Rp1oPL9k3q72TrBEXpEeSaMP3xHimEYmiuMvqe/V7HOTR+sIUm2kD8izs/A4jP7T3b3FXA V1srqPDH/7/tSGNRVYOVAywxhybZyfc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-3NaYKUlPNz-6W4_an8MlkA-1; Wed, 02 Dec 2020 18:39:08 -0500 X-MC-Unique: 3NaYKUlPNz-6W4_an8MlkA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6BB7809DC3; Wed, 2 Dec 2020 23:39:07 +0000 (UTC) Received: from ovpn-66-132.rdu2.redhat.com (unknown [10.10.67.132]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EDDA60854; Wed, 2 Dec 2020 23:39:07 +0000 (UTC) Message-ID: <9d854812b07d8a7516274ea47739158c34cfce08.camel@redhat.com> Subject: Re: [PATCH] mm/swapfile: Do not sleep with a spin lock held From: Qian Cai To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Wed, 02 Dec 2020 18:39:06 -0500 In-Reply-To: <20201202151556.01077710acf79f6fd2ba8287@linux-foundation.org> References: <20201202151549.10350-1-qcai@redhat.com> <20201202151556.01077710acf79f6fd2ba8287@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-12-02 at 15:15 -0800, Andrew Morton wrote: > On Wed, 2 Dec 2020 10:15:49 -0500 Qian Cai wrote: > > > We can't call kvfree() with a spin lock held, so defer it. > > > > Fixes: 873d7bcfd066 ("mm/swapfile.c: use kvzalloc for swap_info_struct > allocatio > n") > > Do you think it's worth a cc:stable? IOW, is this known to ever > produce a warning? Yes, it did trigger a might_sleep() warning.