Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1606714572-1113-1-git-send-email-dikshita@codeaurora.org>
References: <1606714572-1113-1-git-send-email-dikshita@codeaurora.org>
Subject: Re: [PATCH] venus: core: add support to dump FW region
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        vgarodia@codeaurora.org, Dikshita Agarwal <dikshita@codeaurora.org>
To:     Dikshita Agarwal <dikshita@codeaurora.org>,
        linux-media@vger.kernel.org, stanimir.varbanov@linaro.org
Date:   Wed, 02 Dec 2020 23:18:25 -0800
Message-ID: <160697990547.2717324.13284456705336253152@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Dikshita Agarwal (2020-11-29 21:36:12)
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/pla=
tform/qcom/venus/core.c
> index 6103aaf..01a0cfe 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -22,6 +24,48 @@
>  #include "firmware.h"
>  #include "pm_helpers.h"
> =20
> +static int subsystem_dump(struct venus_core *core)
> +{
> +       struct device_node *node;
> +       struct device *dev;
> +       struct resource r;
> +       void *mem_va;
> +       size_t mem_size;
> +       void *data;
> +       int ret;
> +
> +       dev =3D core->dev;
> +       node =3D of_parse_phandle(dev->of_node, "memory-region", 0);

Any chance this could be done at probe time and saved away as some sort
of pointer?

> +       if (!node)
> +               return -EINVAL;
> +
> +       ret =3D of_address_to_resource(node, 0, &r);

of_node_put(node);

> +       if (ret)
> +               goto err_put_node;

And then just return ret;

> +
> +       mem_size =3D resource_size(&r);
> +
> +       mem_va =3D memremap(r.start, mem_size, MEMREMAP_WC);
> +       if (!mem_va) {
> +               ret =3D -ENOMEM;
> +               goto err_put_node;

And return -ENOMEM;

> +       }
> +
> +       data =3D vmalloc(mem_size);
> +       if (!data) {
> +               ret =3D -EINVAL;
> +               goto err_unmap;
> +       }
> +
> +       memcpy(data, mem_va, mem_size);
> +
> +       dev_coredumpv(dev, data, mem_size, GFP_KERNEL);
> +err_unmap:
> +       memunmap(mem_va);
> +err_put_node:
> +       of_node_put(node);
> +       return ret;
> +}
>  static void venus_event_notify(struct venus_core *core, u32 event)
>  {
>         struct venus_inst *inst;
> @@ -67,6 +111,9 @@ static void venus_sys_error_handler(struct work_struct=
 *work)
> =20
>         venus_shutdown(core);
> =20
> +       dev_warn(core->dev, "dumping FW region!\n");

Do we need this warning?

> +       subsystem_dump(core);

Maybe call it venus_do_coredump() so it isn't so generic.

> +
>         pm_runtime_put_sync(core->dev);
> =20
>         while (core->pmdomains[0] && pm_runtime_active(core->pmdomains[0]=
))