Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
AI-Spam-Status: Not processed
Date:   Thu, 03 Dec 2020 17:30:39 +0800
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
To:     Jinyang He <hejinyang@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Huacai Chen <chenhc@lemote.com>
CC:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Loongson64: Fix up reserving kernel memory range
User-Agent: K-9 Mail for Android
In-Reply-To: <1606299062-7427-1-git-send-email-hejinyang@loongson.cn>
References: <1606299062-7427-1-git-send-email-hejinyang@loongson.cn>
Message-ID: <6390E59E-343C-4864-8FFF-87D82CC5097C@flygoat.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E4=BA=8E 2020=E5=B9=B411=E6=9C=8825=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=88=
6:11:02, Jinyang He <hejinyang@loongson=2Ecn> =E5=86=99=E5=88=B0:
>Reserve memory from &_text to &_end=2E Otherwise if kernel address
>was modified, the memory range of start_pfn to kernel_start_pfn
>would be reserved=2E Then we could not use this range=2E

I suspect you meant to make use lower memory after relocation?

Reviewed-by: Jiaxun Yang <jiaxun=2Eyang@flygoat=2Ecom>

Thanks=2E

- Jiaxun

>
>Signed-off-by: Jinyang He <hejinyang@loongson=2Ecn>
>---
> arch/mips/loongson64/numa=2Ec | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/arch/mips/loongson64/numa=2Ec b/arch/mips/loongson64/numa=2E=
c
>index 509b360=2E=2Ec6f0c48 100644
>--- a/arch/mips/loongson64/numa=2Ec
>+++ b/arch/mips/loongson64/numa=2Ec
>@@ -151,6 +151,9 @@ static void __init node_mem_init(unsigned int node)
> 	NODE_DATA(node)->node_spanned_pages =3D end_pfn - start_pfn;
>=20
> 	if (node =3D=3D 0) {
>+		/* kernel start address */
>+		unsigned long kernel_start_pfn =3D PFN_DOWN(__pa_symbol(&_text));
>+
> 		/* kernel end address */
> 		unsigned long kernel_end_pfn =3D PFN_UP(__pa_symbol(&_end));
>=20
>@@ -158,8 +161,8 @@ static void __init node_mem_init(unsigned int node)
> 		max_low_pfn =3D end_pfn;
>=20
> 		/* Reserve the kernel text/data/bss */
>-		memblock_reserve(start_pfn << PAGE_SHIFT,
>-				 ((kernel_end_pfn - start_pfn) << PAGE_SHIFT));
>+		memblock_reserve(kernel_start_pfn << PAGE_SHIFT,
>+				 ((kernel_end_pfn - kernel_start_pfn) << PAGE_SHIFT));
>=20
> 		/* Reserve 0xfe000000~0xffffffff for RS780E integrated GPU */
> 		if (node_end_pfn(0) >=3D (0xffffffff >> PAGE_SHIFT))