Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: vqRKvvXLtKNNYviSac2PJgY8Hu3x4Kgro55YhZlaq0LH7RCryFUMYI3sGSZbncMdmt64s5Eyjw
 0s9LNYif3LRA==
IronPort-SDR: k3CkseoiaZiOxxxG9F8faD5BfisaOL3mZXJaw9e8ZF1mvAsz1GtpafTHilUGtlJfGL7x4v2OOP
 B7gZnTJL9fzw==
Subject: Re: [RFC PATCH v3.1 00/27] Add support UHS-II for GL9755
To:     AKASHI Takahiro <takahiro.akashi@linaro.org>,
        ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, ben.chuang@genesyslogic.com.tw,
        greg.tu@genesyslogic.com.tw
References: <20201106022726.19831-1-takahiro.akashi@linaro.org>
 <20201125074125.GC62993@laputa>
 <c8f7e9ad-3e8d-01cc-edeb-5be364bfcc36@intel.com>
 <20201201030937.GE43403@laputa>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <523f9ed9-318e-7121-d58d-c3843d9b9b7c@intel.com>
Date:   Thu, 3 Dec 2020 11:55:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201201030937.GE43403@laputa>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/12/20 5:09 am, AKASHI Takahiro wrote:
> Adrian,
> 
> Thank you for your review comments.
> 
> On Thu, Nov 26, 2020 at 10:18:55AM +0200, Adrian Hunter wrote:
>> On 25/11/20 9:41 am, AKASHI Takahiro wrote:
>>> Gentle ping;
>>>
>>> On Fri, Nov 06, 2020 at 11:26:59AM +0900, AKASHI Takahiro wrote:
>>>> This is an interim snapshot of our next version, v4, for enabling
>>>> UHS-II on MMC/SD.
>>>>
>>>> It is focused on 'sdhci' side to address Adrian's comments regarding
>>>> "modularising" sdhci-uhs2.c.
>>>> The whole aim of this version is to get early feedback from Adrian (and
>>>> others) on this issue. Without any consensus about the code structure,
>>>
>>> Any comments so far?
>>>
>>
>> Overall, I like this approach of separating UHS2 from legacy sdhci as much
>> as possible.  The only major change, is to drop support for legacy quirks
>> and features that you do not need.  The reason for that, is that there may
>> be few drivers that end up with UHS-II support (opting instead for SD
>> Express), so there is no point going to a lot of trouble to support things
>> that never get used.
>>
>> From what I have seen that looks like it includes:
>> 	- any quirks
> 
> GLI driver (gl9755) needs
>   * SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC
>   * SDHCI_QUIRK2_BROKEN_DDR50
> but they are managed in sdhci code.
> 
>> 	- SDHCI LED support
>> 	- external DMA support
> 
> Should we add 'depends on !SDHCI_UHS2' to MMC_SDHCI_EXTERNAL_DMA?
> 
>> In this regard, the important thing is to have a comment somewhere that
>> lists what is not supported.
>>
>> I have only looked at SDHCI patches so far, and only up to about patch 20,
>> but maybe that gives you enough to go on for a while.
> 
> Well, I have almost done.
> Can I expect your comments on the patches #21-#27 as well soon?

I have made some more comments and that is all for now, except for anything
more you wish to discuss.