Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp394346pxu; Thu, 3 Dec 2020 03:02:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQdtAXMSB7sRI8aBQ88f6q0VHAuvGCLf1wHDx5vwxisji9o0F/dmrxWPUTaZDet6jaLqf6 X-Received: by 2002:a17:906:cc9c:: with SMTP id oq28mr2019527ejb.224.1606993371655; Thu, 03 Dec 2020 03:02:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606993371; cv=none; d=google.com; s=arc-20160816; b=0lkTWt6GqcJeuwd54XADb2ApayQqqJteI+ztFuPcjSeSKRtcnbAWmBWsWnIjmA52id lQibG23jfTT5gxCITERyqWgAvfXzoxsZUi3lhQsNk1kIRtfStjuZjE8Y9BkXjMJyu55e fLqqTLVfda7XC3TlAcKe81MYmzTpGjzzHgM6T1dq2tQL3wV56JAADPmHdMQKk6HwMRhR O9PPSveD2NhXjBW5HBx3J/vlDfNNKs1X2T/Heig5LsRAsJ4Lw1QOTJ0Rw9tV6PwnOBFJ D/1PqfbaRb9WX4dCk7tCJ5B/ND3tPuTabJspjjFxXSmzFoBqYEFL2Oz9gkGVALKnnyLL lhwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=eCBJlUWH+dW7aWaKcrrL+ZaUSjhi3vUF7NMntXueVo8=; b=eXj/lPz+NqJ3/cnoTQ5zRThqYiJefsY/pb8sLtrgtzI6SBzDB4iu1DA2rCAGQZgW6V gqCoVV0QL4ffFGRZjyWRrGCqZY0f2WXBSxxGWKpxtJb3P1d+8+n1oAbmVeHjRljIago7 H3po1Rx66tVXaE5IqVidZ645nSayOu3Zifuex/1jT3Hz155pYGi26X3F64tCxOP6K0ko 68J85TfQLoE+UA9ZDH1rj7wWobldGvxqUkpcXj9JBJeNnku62rpnpDPGkOsFfuQq0gfS X2pOKbuKdAVafPSMlpcLXW0vitZVmTtDrQ7JcIB1Iz5WMm5VXcAOL2ZCLDpwj7W4LmZE Sp4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r8Sr9p4j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u23si687779eds.248.2020.12.03.03.02.28; Thu, 03 Dec 2020 03:02:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r8Sr9p4j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729055AbgLCLAq (ORCPT + 99 others); Thu, 3 Dec 2020 06:00:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgLCLAq (ORCPT ); Thu, 3 Dec 2020 06:00:46 -0500 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1046DC061A4E for ; Thu, 3 Dec 2020 03:00:06 -0800 (PST) Received: by mail-il1-x135.google.com with SMTP id p5so1478447iln.8 for ; Thu, 03 Dec 2020 03:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eCBJlUWH+dW7aWaKcrrL+ZaUSjhi3vUF7NMntXueVo8=; b=r8Sr9p4jQrUiKkGT1lccCyvzLSPvC/tFZoa3kvBITuDo0aNqqwYyEBr4ZX57brV2TI 8ggs1nRgefvljtaew03Sgh2Edd5GsXUTZL6yebMypz2YncmNkHUvmN7BEXv0kild4ABX Wycb4OF1hTuFuNb5GiD8GAP9dx+NYaUX/1UvgGS7wQqugmc2WHnWflsuTY0rKenU1NNU LZ83vNj0dbj4kWWF3kPxv45BsR0eiiblOrp3MHuldTW2iarz6/oNlXqR/Z++sNK+ckk6 yDUySjZc0bx725eOCu+b0TNXkvl7hukrIHn3zE304gfAPa89JlCZuPBp0HIdLJE0mAGp IIgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eCBJlUWH+dW7aWaKcrrL+ZaUSjhi3vUF7NMntXueVo8=; b=uSldumgrQVLWnTPs7lbKgqWOL+PO9pxcxLo29o1XyHFX9twTUW/er9NnoylLkjVIy0 zcXusJ4NWe5V4/qvTCL/fNuUjrocnNRT3MFfM1vq19joOrumRHgnyyoOdEddyd8KEoVH C41z9n4H7wVTP+eeWxf2IBmG72YhVqo3dDUtqG1o/M1EhU/nGl8r/ARYd0XUMznzRONd 8LHZsDH0ZHn4UJnZkh9/J+j/cHf9WFDYn4av17NryoiRNWKOG1I9a1qyHU5dygXAtRqm /prRqV5eP+NaqUo2tVEPvOyjCoJ7Vh2wp7ATOVE+ZltBunoSVmRKOdFsgjN/T3wuFIt7 Iglg== X-Gm-Message-State: AOAM530zlP8n2kNdKkIx7yVbW0Hl27fNA2KXG7lwqVhOgAcVyTB/EXiM mnW6FupJ0bbTpmuAR1bPjq+Qw5M7LNhC6Bg7Ygpp/NpluFo= X-Received: by 2002:a92:8587:: with SMTP id f129mr2473789ilh.251.1606993205259; Thu, 03 Dec 2020 03:00:05 -0800 (PST) MIME-Version: 1.0 References: <280235acc0e91365f3fd3b5be5a5244eced1ff61.camel@perches.com> <20201202183045.9309-1-yashsri421@gmail.com> <5afbcd1423ee8fc2dfad191d94aef6efc17198c8.camel@perches.com> In-Reply-To: From: Lukas Bulwahn Date: Thu, 3 Dec 2020 11:59:54 +0100 Message-ID: Subject: Re: [PATCH -mmots] checkpatch: add fix for non-standard signature - co-authored-by To: Aditya Cc: Joe Perches , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 3, 2020 at 10:59 AM Aditya wrote: > > On 3/12/20 12:26 am, Joe Perches wrote: > > On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote: > >> Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of > >> non-standard signatures. > >> > >> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to > >> non-standard signatures, 43 are due to the use of 'Co-authored-by' > >> tag, which may seem correct, but is not standard. > >> > >> The standard signature equivalent for 'Co-authored-by' is > >> 'Co-developed-by'. > > > > I'm not going to ack this as I don't mind non-standard signatures. > > > > What do you suggest? > Should I drop this patch and move on? > Joe does not ack this, but he also does not nack it. You either move on (which is perfectly fine), or you either wait that Andrew Morton reviews it and accepts it because he thinks it useful, or you reach out to the git committers that have been using Co-authored-by in the past and ask them if this kind of feature would have been helpful for them and you get an ack from them that convinces Andrew Morton to pick this. I hope this helps. If nobody thinks it is a useful feature, move on to work others acknowledge as useful. We have enough stuff to work on. Lukas