Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Dec 2020 13:20:40 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Andi Kleen <ak@linux.intel.com>
Cc:     Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ian Rogers <irogers@google.com>
Subject: Re: [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event
Message-ID: <20201203122040.GO3021@hirez.programming.kicks-ass.net>
References: <20201202150205.35750-1-namhyung@kernel.org>
 <20201202192828.GG1363814@tassilo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201202192828.GG1363814@tassilo.jf.intel.com>
Precedence: bulk

On Wed, Dec 02, 2020 at 11:28:28AM -0800, Andi Kleen wrote:
> > +	prev_cgrp = task_css_check(prev, perf_event_cgrp_id, 1)->cgroup;
> > +	next_cgrp = task_css_check(next, perf_event_cgrp_id, 1)->cgroup;
> > +
> > +	if (prev_cgrp != next_cgrp)
> > +		perf_sw_event_sched(PERF_COUNT_SW_CGROUP_SWITCHES, 1, 0);
> 
> Seems to be the perf cgroup only, not all cgroups.
> That's a big difference and needs to be documented properly.

With cgroup-v2 that's all the same, no?