Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -mmots] checkpatch: add fix for non-standard signature -
 co-authored-by
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Joe Perches <joe@perches.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-kernel-mentees@lists.linuxfoundation.org
References: <280235acc0e91365f3fd3b5be5a5244eced1ff61.camel@perches.com>
 <20201202183045.9309-1-yashsri421@gmail.com>
 <5afbcd1423ee8fc2dfad191d94aef6efc17198c8.camel@perches.com>
 <a2c74693-93ae-cd5a-7836-4ffff643fc09@gmail.com>
 <CAKXUXMxPMdGmnOWdYnS0VQXaAH9dTe7uNfUUPp-GLy2xTXuABw@mail.gmail.com>
From:   Aditya <yashsri421@gmail.com>
Message-ID: <2c0c1501-4e53-85a6-94d5-2082f8e98885@gmail.com>
Date:   Thu, 3 Dec 2020 17:53:43 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAKXUXMxPMdGmnOWdYnS0VQXaAH9dTe7uNfUUPp-GLy2xTXuABw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/12/20 4:29 pm, Lukas Bulwahn wrote:
> On Thu, Dec 3, 2020 at 10:59 AM Aditya <yashsri421@gmail.com> wrote:
>>
>> On 3/12/20 12:26 am, Joe Perches wrote:
>>> On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote:
>>>> Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of
>>>> non-standard signatures.
>>>>
>>>> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to
>>>> non-standard signatures, 43 are due to the use of 'Co-authored-by'
>>>> tag, which may seem correct, but is not standard.
>>>>
>>>> The standard signature equivalent for 'Co-authored-by' is
>>>> 'Co-developed-by'.
>>>
>>> I'm not going to ack this as I don't mind non-standard signatures.
>>>
>>
>> What do you suggest?
>> Should I drop this patch and move on?
>>
> 
> Joe does not ack this, but he also does not nack it.
> 
> You either move on (which is perfectly fine), or
> 
> you either wait that Andrew Morton reviews it and accepts it because
> he thinks it useful, or
> 
> you reach out to the git committers that have been using
> Co-authored-by in the past and ask them if this kind of feature would
> have been helpful for them and you get an ack from them that convinces
> Andrew Morton to pick this.
> 
> I hope this helps. If nobody thinks it is a useful feature, move on to
> work others acknowledge as useful. We have enough stuff to work on.
> 

Okay. I get it now. Thanks a lot Lukas :)

--
Aditya

> Lukas
>