Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp452406pxu;
        Thu, 3 Dec 2020 04:39:27 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwLtjlukygzhfNVQLwqO9/oQ6VaDD2K/JJYOm2PNXau4yeeBaDRMA8AeUMXhTuTRV/S3Z2l
X-Received: by 2002:a17:907:2131:: with SMTP id qo17mr2309489ejb.546.1606999167108;
        Thu, 03 Dec 2020 04:39:27 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1606999167; cv=none;
        d=google.com; s=arc-20160816;
        b=ktc3FlSeB9X3LPl6CexG/YDQprj0G/GWt0tWqI+7htlk1jjf5MmqFfC3t6BF4+SpFJ
         cXdvnLCsoVbsYQ3hSAu8DKBrhFg4S6DuxWYqc+RCDEl/bQ5UwNMUvMTdD6MrRvX+ZKbZ
         hrprk9B1/dwxfXh8rOVwY4QatPLYxSNWFXSUyJa8iY4cgQ/skccfl1TydwhXuQBgayjo
         mdZ4ReSvBTfNRlNJa6fNwd2Er4TcKghXyFhQK5opJObuiK/5ZYvFXsrk0QnjYkcYC8e/
         1mjEPXBeBb0jOApRf+yYYJQUgT8x6kZZA2Xg/YWrWOtqg3IpTIrmsfaDYWcn9zaL0X55
         WQnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=Ghno+0cw8VXLyR9YQiz+AJ5XgUJGy4a+e880bHMHFfc=;
        b=w8fYrSk09nuAoBRMe8WTrWss3/V22GMDL+eBrCvuu9Ej9ZkgPoh9IPtN+lKxByi4MG
         hpVH/tvpzS1ifeCoeinBoBGgYXwHYHJH/hhBWfXXF4dJ2JL3o3tvfwz1CfssZjskfx1n
         9eScVRp7ptt2BKjBanPt9O5d/BcM4h2vkdexzNrRlUsexJNUf8yV3KgqqOggY4/WPieT
         hvV/I5NRjjB6hnllS+mVzdKr7XVsduEdR18bNcd/YwhrqA4LhAniq1zkh39T9+pfjDRW
         ljIR9ESfiSMgpo/MwX1PS2hdNqGgO8z13JyQiCT0v1iilKG+rxB6Et1hBzDaK04AXJlA
         4anw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Qlpx4OVo;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id w14si1042098eje.646.2020.12.03.04.39.02;
        Thu, 03 Dec 2020 04:39:27 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Qlpx4OVo;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2387961AbgLCMh1 (ORCPT <rfc822;proy.cse@gmail.com> + 99 others);
        Thu, 3 Dec 2020 07:37:27 -0500
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:14390 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726213AbgLCMh0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 3 Dec 2020 07:37:26 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5fc8dbdd0002>; Thu, 03 Dec 2020 04:36:45 -0800
Received: from [10.25.75.116] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 3 Dec
 2020 12:36:37 +0000
Subject: Re: [PATCH V4 1/6] PCI: tegra: Fix ASPM-L1SS advertisement disable
 code
To:     Thierry Reding <thierry.reding@gmail.com>
CC:     "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "amanharitsh123@gmail.com" <amanharitsh123@gmail.com>,
        "dinghao.liu@zju.edu.cn" <dinghao.liu@zju.edu.cn>,
        "kw@linux.com" <kw@linux.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Krishna Thota <kthota@nvidia.com>,
        Manikanta Maddireddy <mmaddireddy@nvidia.com>,
        "sagar.tv@gmail.com" <sagar.tv@gmail.com>
References: <20201109171937.28326-1-vidyas@nvidia.com>
 <20201109171937.28326-2-vidyas@nvidia.com> <X7+Sc5Mtp4OvrO4P@ulmo>
From:   Vidya Sagar <vidyas@nvidia.com>
Message-ID: <595c4616-71b9-e8bc-3300-c1c04503b850@nvidia.com>
Date:   Thu, 3 Dec 2020 18:06:33 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.2
MIME-Version: 1.0
In-Reply-To: <X7+Sc5Mtp4OvrO4P@ulmo>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1606999005; bh=Ghno+0cw8VXLyR9YQiz+AJ5XgUJGy4a+e880bHMHFfc=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
        b=Qlpx4OVoWkjIieVyxRsOLiyKJ6yry2N4poCWtoYDtPmp2LZVvqCiZARKJbGLwzUTq
         TQRx8ocQe3YxH/aUxY1Jzvpxi1QsT1DjAUagqCi8PPoly5P05QzU39ONESEIOEwPeq
         /uejJMxNciNEM/l2elVBJyBKNlp0cKpAroXrSr8vo5qpkdgZ2mHw/rgLUW2p7mQpWC
         qHa+x/HzmdTO7Ba+kEIpwtvSzDIKnXp4lMT15+RdwOmJAvNsHLT/W1CyaKGuL3IJKh
         JHbLoqdGYxRiZjrz/RHU40P5te31f8cKyaEdXCWZMDTv8CNO72d4mWVxhHOmz0Y8Mr
         4Rs/D0K0WGzHg==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



> -----Original Message-----
> From: Thierry Reding <thierry.reding@gmail.com>
> Sent: Thursday, November 26, 2020 5:03 PM
> To: Vidya Sagar <vidyas@nvidia.com>
> Cc: lorenzo.pieralisi@arm.com; robh+dt@kernel.org; bhelgaas@google.com;
> Jonathan Hunter <jonathanh@nvidia.com>; amanharitsh123@gmail.com;
> dinghao.liu@zju.edu.cn; kw@linux.com; linux-pci@vger.kernel.org; linux-
> tegra@vger.kernel.org; linux-kernel@vger.kernel.org; Krishna Thota
> <kthota@nvidia.com>; Manikanta Maddireddy <mmaddireddy@nvidia.com>;
> sagar.tv@gmail.com
> Subject: Re: [PATCH V4 1/6] PCI: tegra: Fix ASPM-L1SS advertisement disable
> code
> 
> On Mon, Nov 09, 2020 at 10:49:32PM +0530, Vidya Sagar wrote:
> > If the absence of CLKREQ# signal is indicated by the absence of
> > "supports-clkreq" in the device-tree node, current driver is disabling
> > the advertisement of ASPM-L1 Sub-States *before* the ASPM-L1
> > Sub-States offset is correctly initialized. Since default value of the
> > ASPM-L1SS offset is zero, this is causing the Vendor-ID wrongly
> > programmed to 0x10d2 instead of Nvidia's 0x10de thereby the quirks
> > applicable for Tegra194 are not being applied. This patch fixes this
> > issue by refactoring the code that disables the ASPM-L1SS advertisement.
> >
> > Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support")
> > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > ---
> > V4:
> > * None
> >
> > V3:
> > * None
> >
> > V2:
> > * None
> >
> >  drivers/pci/controller/dwc/pcie-tegra194.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> Looks like this no longer applies cleanly after that other fix that you sent earlier.
> But looking more closely, that's because that other fix already incorporates an
> equivalent change, so I think this can be dropped from this series.
Yes. This is no longer applies cleanly and I'll fix it in the next 
series, but, the current patch is still required.
The other change I pushed is taking care of getting a valid 'dbi' 
address before accessing the dbi region, but, this current change would 
make sure that 'pcie->cfg_link_cap_l1sub' would have a valid value 
before calling disable_aspm_l1/2() APIs.

Thanks,
Vidya Sagar
> 
> Thierry