Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp492051pxu; Thu, 3 Dec 2020 05:41:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwoibZTCycd5jgESBunWVrFQnUARkaCD602vl25CEdT7CcwREO9c+G20el1kGX5E4MGkLI2 X-Received: by 2002:a17:906:38c8:: with SMTP id r8mr2615864ejd.39.1607002878012; Thu, 03 Dec 2020 05:41:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607002878; cv=none; d=google.com; s=arc-20160816; b=0IpaLwmQmgDW1m7uc/io+GpCQXplR9S7iWWAbXWKSEPn7jBYC0Po+Ty+YEQRmBuIvc TDm4zl1d38QNy7fO07cfCGAPv4jhHGLFuY9zzsVhXXtQKOo8tOBasghj/N1tqVKE3j6Y j4h1AmbhDvsZJXU1EV7S+Njg5Lob+aWIm4PeMrfa9/RYGn0X35gqJvLitHD5aTMIvF/8 Yhbz5EUUx27VWxwE/zXGSRhs+5ZvMEEzn6W8xdwbf781vuaEpEFIVM4E8Sqs9nZ9Ywh5 q8YNp6klOJ656W5271LpIGl8kMpYWIJS+iFLZ4u3j1cL5OH2b5roYmpzsOpiCio9425Q //vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ePKiGbeIENr9q/vgaSBsBvB7ieTNYt9P1jRssh2NtTA=; b=LOC17i87GaMCKbcktfqhEJ+vzySRNnMeZ8q6xAh+/mkFvMyXUkD+2hIAUqu/iaEsjQ r7TYd6il3cxzCpdPeLpySUVn552056iixjrjMXH2ywTql+J0ApfwKEFak7u4lYl43dGx C7H0z/06Qt7VeHjhvcG23jHiM27rIf35lRDq9lpSG1FPIHdaZbd3iA8oaNjh9nI/owJU r5f0vIfExGklEpOxrPKwppYfkCeum7poqSCIgGR9kXal7pSfJH3ch51RhmmLadUz5sBp 2bXXiWwml/Tcl/StN6IJDdjtH8cIS0fkXNF8iVHdXxpwMuteAxLD4UbFlCqK2AoUAM5k IkdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca22si657095ejb.688.2020.12.03.05.40.53; Thu, 03 Dec 2020 05:41:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437081AbgLCNgj (ORCPT + 99 others); Thu, 3 Dec 2020 08:36:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:48860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436666AbgLCNak (ORCPT ); Thu, 3 Dec 2020 08:30:40 -0500 From: Sasha Levin Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Oded Gabbay , Sasha Levin Subject: [PATCH AUTOSEL 5.9 23/39] habanalabs/gaudi: fix missing code in ECC handling Date: Thu, 3 Dec 2020 08:28:17 -0500 Message-Id: <20201203132834.930999-23-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201203132834.930999-1-sashal@kernel.org> References: <20201203132834.930999-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oded Gabbay [ Upstream commit 652b44453ea953d3157f02a7f17e18e329952649 ] There is missing statement and missing "break;" in the ECC handling code in gaudi.c This will cause a wrong behavior upon certain ECC interrupts. Signed-off-by: Oded Gabbay Signed-off-by: Sasha Levin --- drivers/misc/habanalabs/gaudi/gaudi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c index 2e55890ad6a61..8da1720357a26 100644 --- a/drivers/misc/habanalabs/gaudi/gaudi.c +++ b/drivers/misc/habanalabs/gaudi/gaudi.c @@ -5416,6 +5416,8 @@ static void gaudi_handle_ecc_event(struct hl_device *hdev, u16 event_type, params.num_memories = 33; params.derr = true; params.disable_clock_gating = true; + extract_info_from_fw = false; + break; default: return; } -- 2.27.0