Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp614237pxu; Thu, 3 Dec 2020 08:28:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzm72X2qYJ5Ct5Ru5NOMt1OtORG2392ZBlkx5FRjAo0YRSABWah7D4Xv90SQsqThTCRukdk X-Received: by 2002:a17:906:fa88:: with SMTP id lt8mr3273055ejb.408.1607012884498; Thu, 03 Dec 2020 08:28:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607012884; cv=none; d=google.com; s=arc-20160816; b=ppF/R8lmvjM+arPlQxrIq/tFBRisq3gSTJWHFDV4uzcnH66g7N3O+6p0smT+JHomFI y7nBOfiBzhdOSvQ9/1x252unN/RBSMXeVqZSmSt8TKxont/IpS9MUzUJ/j2jcT6R3X98 xJLc6dT9Feq8FDaIj2lH9IJqbSLbXfyhi+yLV7h7Q1oObHSoCT8QjfPabqHmsCDTE4My aRZc4x92FdBhijkPYQMKCrZnCJ5V8W7SDnKSLvCxkjABsR7qF0k76aCWsRCZ/+aKSHa6 k7SkVrf/l4g0uOxWrTqOVOF2KHlXkLvID1O4p4fdSZ81Gfaieqj24lWUzGbk/g/g8rha tpzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=S3AFaUzJoub60vRRyYRzulKzsuGYCd0b4YS/6BXU4Dc=; b=XUjB30znzCT1bZ2VR2M56O5zX3lUPJBHYnMwTSILYd24qWbhKTjUBo/9YUJ1yvIW4R VKl/KYMHLLJJfhC1qvgVPYEoUesp4izR2mzMWMCGnMcoswH2dMR1GcrYecKxLfKG+Zmy f8fHYXfw2nPIHGmh+lKxJYqi4xmfUewL7bQ7oQlYMRlIMRbdjFh2y5iOZjWRKMk24F+m UpAopXzjBlpdYWhgg0+hGmRF12pqWWqNeSxYaMTi7HTN45oZ6N44jAOmoLVvOgRPCzrQ 8G3uQmJ3vGHKGv3uXvK1thJWBLPjlO2bquNlWFiroUQLbYgn4BfBoxkRQul6ltLoGqFI 0G8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=hwn3l4YL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cb26si1201096edb.382.2020.12.03.08.27.40; Thu, 03 Dec 2020 08:28:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=hwn3l4YL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436784AbgLCQXT (ORCPT + 99 others); Thu, 3 Dec 2020 11:23:19 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:55826 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436766AbgLCQXS (ORCPT ); Thu, 3 Dec 2020 11:23:18 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0B3GM93X012653; Thu, 3 Dec 2020 10:22:09 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1607012529; bh=S3AFaUzJoub60vRRyYRzulKzsuGYCd0b4YS/6BXU4Dc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=hwn3l4YL0YRj6YxNfaNfh5x4GsJiSCeWKe3dY0HiyfLmlAnxmzk1vEIsL5lxONW+G n95O7cNzNnq37qxWEQb9In92+gOcg0BF6gp0Os6UGEXQcbvHUyJOyh/Fx7v8ZMoKM0 llqiXQOwNhBzyZFxNySYLG/UGhdB5RsGoE7i1ouA= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0B3GM8aR127125 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Dec 2020 10:22:08 -0600 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 3 Dec 2020 10:22:07 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 3 Dec 2020 10:22:07 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0B3GM5r6078920; Thu, 3 Dec 2020 10:22:06 -0600 Subject: Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support To: Andrew Lunn , Vignesh Raghavendra CC: "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Jiri Pirko , , , , Linux ARM Mailing List References: <20201130082046.16292-1-vigneshr@ti.com> <20201130082046.16292-2-vigneshr@ti.com> <20201130155044.GE2073444@lunn.ch> <20201203141838.GE2333853@lunn.ch> From: Grygorii Strashko Message-ID: Date: Thu, 3 Dec 2020 18:22:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201203141838.GE2333853@lunn.ch> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/12/2020 16:18, Andrew Lunn wrote: >> We don't want to enable HW based switch support unless explicitly >> asked by user. > > This is the key point. Why? Does individual ports when passed through > the switch not work properly? Does it add extra latency/jitter? When switch mode is enabled the forwarding is enabled by default and can't be completely disabled, while in multi port mode every port and switch tables (ALE) configured so no packet leaking between ports is happen. The multi port is the requirement for us to have as default mode no mater to what upper interface ports are attached to LAG, LRE (HSR/PRP) or bridge. Switching between modes required significant Port and ALE reconfiguration there for technical decision made and implemented to use parameter for mode change (by using devlink). It also allows to keep user interface similar to what was implements for previous generation of TI CPSW (am3/4/5). -- Best regards, grygorii