Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp632654pxu; Thu, 3 Dec 2020 08:54:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxsNgnR145t8eiAVrm+PyXqfck9xT7t9y5fuNqfzIZoxP+y9EeSkLAe84sqpax/dUPGQUvI X-Received: by 2002:a17:906:878d:: with SMTP id za13mr3303674ejb.395.1607014475664; Thu, 03 Dec 2020 08:54:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607014475; cv=none; d=google.com; s=arc-20160816; b=G7aHKurkdttpwAVKsqHSYWFEAMe+j31l3UjHVaT8pseuCx4YucznF0Kpp2ecQ2Dumx QeoAjpT9bEmao2i/3qHTF/jcupmdzOR+phL0pv1hKxlEN7kVZ/lpBXzNNQj7XHDsrLrN qH5BK0jO59BFo+Q6Xmq5rcoby+6sji3X75o3NILmr+Kwh/I0ZM8sVcyL2ga4fwATr1Vv ImcA+plqRCYsrW9lvSpd+rMdqqUbGGPKNAQs2G6vX5snQZiKyopZoTvO5QCZOf9g6tFJ us2JSNmi/hxohhzmBXwyJRF+qT7lezlR2S4S0y4lqBJdEqRdoYNW/Yld1JiNqsk3LeYs ZW0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=CUFCC9lmPX04vZzUsIzOjedjoMgF9NkwMZKoMwGRDY8=; b=YlAVRRpEb5pPHl1FWmOMizm0fuGVmmLSlhNrgB8fxOhoBi6kfpe3Szv7zktB61MFjc rGRqKMjUMcXh2A+Ido4fEP1YfI1rhAowVdonOyEfbP8Oa3mOfs+IVnKktNlOE+MbesD6 E1gJzBP2IxOm8doGzlnBWLBKEuDzN4Xd0Krg2yTv4Qu8yJ9RToilHLmY67MwSDmLaQTA yb4rdDsIQgPKhp+p4D7QV/q4gfF1EvuFLaBzzmYbwWxzwGSUjGdcclGNcjS14kkNIE+C WGUA4cdZA89XCHQvuVAMaPEwQqRfzbj2oGjH9RgSiQISWPWBZx+gUGNSMeYkJFtJNFNm 78UA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id el22si1433682ejc.362.2020.12.03.08.54.12; Thu, 03 Dec 2020 08:54:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729348AbgLCQv0 (ORCPT + 99 others); Thu, 3 Dec 2020 11:51:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:53642 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728734AbgLCQv0 (ORCPT ); Thu, 3 Dec 2020 11:51:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 295D8AC2E; Thu, 3 Dec 2020 16:50:45 +0000 (UTC) From: Mian Yousaf Kaukab To: lorenzo.pieralisi@arm.com, tjoseph@cadence.com Cc: robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, Mian Yousaf Kaukab , stable@vger.kernel.org Subject: [PATCH] PCI: cadence: Fix cdns_pcie_host_setup() error path Date: Thu, 3 Dec 2020 17:49:44 +0100 Message-Id: <20201203164944.2257-1-ykaukab@suse.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit 19abcd790b51 ("PCI: cadence: Fix cdns_pcie_{host|ep}_setup() error path") removed pm_runtime_put_sync() call from the error path in cdns_pcie_{host|ep}_setup(). However, the hunk in cdns_pcie_host_setup() got lost. Fix error path in cdns_pcie_host_setup() by removing pm_runtime_put_sync() call. Fixes: 24344226f66b ("PCI: cadence: Use struct pci_host_bridge.windows list directly") Cc: stable@vger.kernel.org Signed-off-by: Mian Yousaf Kaukab --- drivers/pci/controller/cadence/pcie-cadence-host.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/pci/controller/cadence/pcie-cadence-host.c b/drivers/pci/controller/cadence/pcie-cadence-host.c index 811c1cb2e8de..6e2557653943 100644 --- a/drivers/pci/controller/cadence/pcie-cadence-host.c +++ b/drivers/pci/controller/cadence/pcie-cadence-host.c @@ -471,14 +471,5 @@ int cdns_pcie_host_setup(struct cdns_pcie_rc *rc) if (!bridge->ops) bridge->ops = &cdns_pcie_host_ops; - ret = pci_host_probe(bridge); - if (ret < 0) - goto err_init; - - return 0; - - err_init: - pm_runtime_put_sync(dev); - - return ret; + return pci_host_probe(bridge); } -- 2.26.2