Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drivers: acpi: add opt-out of Apple-specific property
 parsing
To:     "Enrico Weigelt, metux IT consult" <info@metux.net>,
        linux-kernel@vger.kernel.org
Cc:     linux-acpi@vger.kernel.org
References: <20201203174453.12084-1-info@metux.net>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <88bb006f-27bd-7be6-19b5-6b879f1df131@infradead.org>
Date:   Thu, 3 Dec 2020 10:19:59 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20201203174453.12084-1-info@metux.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/3/20 9:44 AM, Enrico Weigelt, metux IT consult wrote:
> Most x86 machines aren't Apple machines, especially VMs.
> Therefore allow opt-out, making the kernel a few KBs smaller,
> eg. for embedded or high-density VMs.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
>  drivers/acpi/Kconfig    | 9 +++++++++
>  drivers/acpi/Makefile   | 2 +-
>  drivers/acpi/internal.h | 2 +-
>  3 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index edf1558c1105..cc47de4f2b18 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -79,6 +79,15 @@ config ACPI_DEBUGGER_USER
>  
>  endif
>  
> +config ACPI_APPLE
> +	bool "Apple ACPI properties support"
> +	default y if X86
> +	help
> +	  Extraction of Apple-specific ACPI properties.
> +
> +	  Say N if you're sure the kernel won't be used on an Apple machine
> +	  and wanna save a few kb of memory. (embedded or high-density VMs)

	      want to

As I have said before, don't use "kb". It means kilobits. We don't normally
measure memory in kilobits.


Did you read all of my previous email?


> +
>  config ACPI_SPCR_TABLE
>  	bool "ACPI Serial Port Console Redirection Support"
>  	default y if X86

-- 
~Randy