Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp769652pxu; Thu, 3 Dec 2020 12:09:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJzYjnTOgL4vHVoQD4lFzmO51UneGoMEUwfW6kCakBALRHeuDB39FYmFIYXD63OMy4ha1sXF X-Received: by 2002:a05:6402:22ea:: with SMTP id dn10mr4395443edb.67.1607026166149; Thu, 03 Dec 2020 12:09:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607026166; cv=none; d=google.com; s=arc-20160816; b=S6iPxzmRjV7xzHwAfqMC0qyvq9Nf+G9hs/ssMI/zWQDM9ji9FEPlc+U701Mc+KimJG lMi3po1jP8c4wvc+QqwYktiPTWXEGVcWswnepjX583YU/2gW1vFhIAOxgGP6pBB8gGY9 m2/TFww4c4LSKzULbLWAhtOZLyPNEl2EWWwdjbGGugrfnmww/Pzx9R5wE95I5NFmvvgd fEp+KxioKaIOUwHzBxsVAD6txWOjAmpHqEHU8lYk1H5Q269SedVoxqNy2l5FwNJleWlm ESwA+PuUrRGQRA+yLzi3e1jgyrMHgjYVXDRS6rPUk0RabIF48clpG81XWrgQhpJezyJW sQgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature:dkim-signature; bh=EhuajtNC0vEMasKkbq3R995VQBB0+sh/Q5q9ed8kJVc=; b=Hy11MypHRXEvYFVUFfrNzNjG3RJ6wf4SFMkoxW+NkSKqOBcxeTaP9aIDDl2dwYRyqc wppL6lIVY7YNllqqIW3o6OsV37sjEI1DXsRts0Z/tsMc9/cCcuZoVh1uOBADHu5/bdsp RDWRky5v10Hpv6QcoLJJasd0m6YDdwrFfZf7eG4r/ly3QK4SoV7wbdgFCUrTxDT8O70Q Gu7RfS0I/WYImx52kDBCUeJcA1uEx2b6dgsb5XGjGg79DBlrfHchzkaNNzBMBslP3/qc JN2SodOOyhQEh/Qwj99pLxcDwVwytpgPtiUpnfSMNAqXNgQ73aGtpLpBjUEZF0jh5TBH 7mag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=qZBF4ptS; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=qZBF4ptS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y15si9008ejp.228.2020.12.03.12.09.00; Thu, 03 Dec 2020 12:09:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=qZBF4ptS; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=qZBF4ptS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbgLCUEu (ORCPT + 99 others); Thu, 3 Dec 2020 15:04:50 -0500 Received: from bedivere.hansenpartnership.com ([96.44.175.130]:56838 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbgLCUEu (ORCPT ); Thu, 3 Dec 2020 15:04:50 -0500 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 22AA71280B71; Thu, 3 Dec 2020 12:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1607025850; bh=HexzAZacNggZxtGW31Mcyz0+xUVZxQ1FJZ1MlQz9IPs=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=qZBF4ptSr8bG0N4UTqqqmJAjjjQTV06ac3tcNPrvLRFQ6fPUe8U98bOIAR1STlNHs Isk5fuj6+OM7y3EYvnLvyuyt8ISVWiEnpOTBeGQx3pNDLiRyWdQmr3RrfFvYwzO25E GKW5gYxCTJFfJuz44OYtBLi0UE9zkNkb+/PmW2uY= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t5uHidc9ZBPY; Thu, 3 Dec 2020 12:04:10 -0800 (PST) Received: from jarvis.int.hansenpartnership.com (unknown [IPv6:2601:600:8280:66d1::527]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id B9BB11280B6F; Thu, 3 Dec 2020 12:04:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1607025850; bh=HexzAZacNggZxtGW31Mcyz0+xUVZxQ1FJZ1MlQz9IPs=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=qZBF4ptSr8bG0N4UTqqqmJAjjjQTV06ac3tcNPrvLRFQ6fPUe8U98bOIAR1STlNHs Isk5fuj6+OM7y3EYvnLvyuyt8ISVWiEnpOTBeGQx3pNDLiRyWdQmr3RrfFvYwzO25E GKW5gYxCTJFfJuz44OYtBLi0UE9zkNkb+/PmW2uY= Message-ID: <147e17a3a1e54d46611b285a973c03f14b19dc96.camel@HansenPartnership.com> Subject: Re: [Ksummit-discuss] crediting bug reports and fixes folded into original patch From: James Bottomley To: Matthew Wilcox Cc: ksummit , Vlastimil Babka , LKML Date: Thu, 03 Dec 2020 12:04:08 -0800 In-Reply-To: References: <694039d6e386d999fd74d038cf2627f5b3b0ca71.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-12-03 at 13:52 -0500, Matthew Wilcox wrote: > It's not so much "clean history" that's the desire. It's "don't leave > landmines for git bisect". ... top posting? Well functional git bisect and show the evolution of the patch aren't mutually exclusive. Plus our current clean history approach doesn't always detect them ... That said, I agree that if a review comes in that shows a patch would break the build or runtime in a way that would damage bisection, it should be folded. I suppose this argues that only less trivial changes can be shown as part of the unfolded history, and since they're obviously less important than the review driven folded change it would add more bias to track them. I fall back to my link is enough comment. James