Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp796128pxu; Thu, 3 Dec 2020 12:53:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWdCwD5j6p5bqYp1r7H5fShK0chSoSNEzmgDswNTGRCuGJYVcnknVyWFqW56s/juzW+pIZ X-Received: by 2002:a17:906:3a4e:: with SMTP id a14mr4265153ejf.140.1607028796797; Thu, 03 Dec 2020 12:53:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607028796; cv=none; d=google.com; s=arc-20160816; b=J63rZeJcmbaijyhDbai2/qUrmh9LjTKXvjEt4fKtrsP3C+EaISJNh6UUB/z0myNJgN MjTrh/3SyjYsMQZcefdHqPpECo9BBAILSVYeZdeD8izvOtZnK2taU37uGFF6TnGqc9Ss Tx/fgGb0aOYJRkKsuFLLcaEnUXnIqe/6bV9CkmeKpbJym4EUbBqcad/qF3f4kjsBl/VD DB9sDAGRMiXjgNQRWKLW1+jnfVEGisx0yWTMadpquHzmkyJ6RVYWLa/SApQxsnNX4xYj AurtYgYYyOWcAuay6via+OXd0JwPoyd67CWUoPJ55XJxsZGXu4ThqZ9IJGIK+ZrDUtrY JR9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1LXP9D1+B9hUfYyzLOZtgb+vEzU/N5ctuPzRovVvNtU=; b=uuy8eeWuFRUZ9ZxGxeVVUXT0nbVx2na7MvwvLq6Yq4MmhgNcrd9+rVzBJBMPh2xPR1 Jo/CkUHAFeMF/iK4nRU4LygKgP+2QZ8qzotl+D3KEeVUtbYldrarrP+EVbyIrVteqMIx HVDncCq4c8+YqZjFykkgN10lWORAz8nBGoD0Yiu3jbf4PBQnOSRnf+tSnm4eAZL1vYTj l7W+Qq6IlrUZi0a0FaMFwF9TrgpPhGyoa/UMwFcLlebqxl5SqmAvjvFBVTo3zDyKUchU +f5vLtB1nj44DZjxHKMsz83J4OZEq3hteD2GywvmjWP/Q2ujgWrrwvkvT8UtzNWOZq5Y +/6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=adNHtY5D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh18si87465ejb.374.2020.12.03.12.52.53; Thu, 03 Dec 2020 12:53:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=adNHtY5D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387473AbgLCUsB (ORCPT + 99 others); Thu, 3 Dec 2020 15:48:01 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:46630 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbgLCUsA (ORCPT ); Thu, 3 Dec 2020 15:48:00 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B3Kj8Ru030892; Thu, 3 Dec 2020 20:45:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=1LXP9D1+B9hUfYyzLOZtgb+vEzU/N5ctuPzRovVvNtU=; b=adNHtY5Dw7BRWavEq09fQxsusSS1HmYNQHluL3XKAl2nK4yJIuTzXdrvSNVoWY6IJUfE MtyMFUXdgczzoxTp6+AhbXxf2G0Di19f3LvDGzPJFHnWsPzGzOtq3F0YErEB1kWfn6eH zkRM4uvzOD9uoMMwh/bUppdeJc5HiBrHR4ewaTBAjQw0e1yKAApX7hvJ5msCdgJnskWC ylZWnWZjtVtnjKlFqSkBGC9ifXx7WwuyBNL7utJJyIX9m2bSCNxzSlAwfZj82M6UncVn 2wTPYJIqYrWsmaixYWuHs2XU5vnYJrbkqdpPFf+qxQO4u+aMNhzaLX5FCBLtmO2RKp2c +Q== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 353c2b883v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 03 Dec 2020 20:45:08 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B3KdSLD029552; Thu, 3 Dec 2020 20:45:07 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 3540g2ds87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Dec 2020 20:45:07 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0B3Kj4ai031535; Thu, 3 Dec 2020 20:45:04 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 03 Dec 2020 12:45:03 -0800 From: "Martin K. Petersen" To: Subbu Seetharaman , Dan Carpenter , Thomas Lamprecht Cc: "Martin K . Petersen" , jejb@linux.ibm.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, stable@vger.kernel.org, jitendra.bhivare@broadcom.com, linux-scsi@vger.kernel.org, jayamohank@hdredirect-lb5-1afb6e2973825a56.elb.us-east-1.amazonaws.com, James.Bottomley@suse.de, ketan.mukadam@broadcom.com, Greg KH Subject: Re: [PATCH] scsi: be2iscsi: revert "Fix a theoretical leak in beiscsi_create_eqs()" Date: Thu, 3 Dec 2020 15:45:01 -0500 Message-Id: <160702820882.27665.13232983618301808305.b4-ty@oracle.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9824 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=971 adultscore=0 mlxscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012030121 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9824 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 lowpriorityscore=0 clxscore=1011 bulkscore=0 mlxlogscore=982 phishscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012030121 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Dec 2020 15:18:26 +0300, Dan Carpenter wrote: > My patch caused kernel Oopses and delays in boot. Revert it. > > The problem was that I moved the "mem->dma = paddr;" before the call to > be_fill_queue(). But the first thing that the be_fill_queue() function > does is memset the whole struct to zero which overwrites the assignment. Added Cc: stable and applied to 5.10/scsi-fixes, thanks! [1/1] scsi: be2iscsi: revert "Fix a theoretical leak in beiscsi_create_eqs()" https://git.kernel.org/mkp/scsi/c/eeaf06af6f87 -- Martin K. Petersen Oracle Linux Engineering