Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp807014pxu; Thu, 3 Dec 2020 13:10:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJypm1zpUwC25haAHbSWEn7oY5RVOxR6s+Ia6mpzLN6ZPrZ7fibe1Tk6mMHsLl0pklVbBPvP X-Received: by 2002:a17:906:a0c3:: with SMTP id bh3mr4293771ejb.497.1607029834049; Thu, 03 Dec 2020 13:10:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607029834; cv=none; d=google.com; s=arc-20160816; b=yonLnOo+jHcMyWyNnSHYwzpAYftVcHNAEOhtkC4qB7F2YJMYC9+KjAScRI4Q2IXvco 6oiGl+gGYWvrZgwCjK9Os/jZcZ0tHNQ6xkpeZwS+G++JVMuZMQ88NHJRDIg7/z9vwq2H cE/hnXkLbxjZcAqsdKTa2s74m8Qso7RP/m3RW41Uyn9obcstWb/LWGaD1MGjau5p1bDH Ze0j/Iu7WvY5ihTMY5pH+e4i1FmswZB6vtrDJRu256EJLBhjR5yjUGiuKU6xWxV1NumZ pOQgvENBM7hvG1m246owdbkkeuZSPn0SEP9W2QiSDIo7fGGF2SN91swWvungJ+0CAXUc BK9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature:dkim-signature; bh=gupyYlDBS0GbDKuSAg3qbZdUT0U9DMtDXTCAMUtXwQQ=; b=GUpBHHLZ2Tn1Q9EKMv+CauEWKL1lB2fPts6foXeSMYLGnW14fp1qHuEdV7DWnDVuFw AE2ZXArPgwcaihhb4hcfcHwQnzkxD/EK8CSgTBCjp7lAyWUkXuL7LKHuzTBDV82zjUuW +X5MQ/AbxzvhDslovGx6UhA+AnlUAW+xQ5ej5axyVyucYWyNfWDNZYKfPl0h7Vi9jlCu XMP9Eu465dYjpS4CYBK4hGI1s3dC6hZZCckOZg8i4eGWXF+A5QNkNwcKeGVduSrNEezz HPDIinYORXry9vNGOizThcu8tcRFuNo8Qpp8QeAdizYZH6rZEU1aNE3agbKujPg8MpD2 XRUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=VYxKisDf; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=VYxKisDf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gr1si99806ejb.742.2020.12.03.13.09.47; Thu, 03 Dec 2020 13:10:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=VYxKisDf; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=VYxKisDf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727413AbgLCVFo (ORCPT + 99 others); Thu, 3 Dec 2020 16:05:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgLCVFo (ORCPT ); Thu, 3 Dec 2020 16:05:44 -0500 Received: from bedivere.hansenpartnership.com (bedivere.hansenpartnership.com [IPv6:2607:fcd0:100:8a00::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3430DC061A52; Thu, 3 Dec 2020 13:05:04 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id D2B7F1280B66; Thu, 3 Dec 2020 13:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1607029503; bh=UJ0dzKgWGj+kvvVqBtel3X5aOa+jAsa2wG7ghTAbBEo=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=VYxKisDfLldXRZXHEJyGu9KD47lVB4LMxIgAQM2atEPg3xI2Z5BNBt8KnPzru/Ucw mzzXzHFaABbbFB/jKeoZmyJ7tf6wOTD1yNNUpsSHZuV3PklBCVhfri2S9kDGSuD5Rz BlkPrF7MKFWOAWGjedkcA7Ufg/oAol1JPZ0LP6DA= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mTgAhRg7TuSj; Thu, 3 Dec 2020 13:05:03 -0800 (PST) Received: from jarvis.int.hansenpartnership.com (unknown [IPv6:2601:600:8280:66d1::527]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 43BC41280B60; Thu, 3 Dec 2020 13:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1607029503; bh=UJ0dzKgWGj+kvvVqBtel3X5aOa+jAsa2wG7ghTAbBEo=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=VYxKisDfLldXRZXHEJyGu9KD47lVB4LMxIgAQM2atEPg3xI2Z5BNBt8KnPzru/Ucw mzzXzHFaABbbFB/jKeoZmyJ7tf6wOTD1yNNUpsSHZuV3PklBCVhfri2S9kDGSuD5Rz BlkPrF7MKFWOAWGjedkcA7Ufg/oAol1JPZ0LP6DA= Message-ID: <8a7d2fda891e45b098b603064d45dd7d53898fd4.camel@HansenPartnership.com> Subject: Re: [PATCH v2] tpm_tis: Disable interrupts if interrupt storm detected From: James Bottomley To: Jerry Snitselaar , Jarkko Sakkinen Cc: Jani Nikula , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Jason Gunthorpe , Peter Huewe , Matthew Garrett , Hans de Goede Date: Thu, 03 Dec 2020 13:05:02 -0800 In-Reply-To: <87ft4mpryt.fsf@redhat.com> References: <20201130232338.106892-1-jsnitsel@redhat.com> <20201201025807.162241-1-jsnitsel@redhat.com> <87czzujjg1.fsf@redhat.com> <878sahmh5w.fsf@redhat.com> <20201202164931.GA91318@kernel.org> <87sg8noixh.fsf@redhat.com> <87lfefe7vm.fsf@redhat.com> <87ft4mpryt.fsf@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-12-03 at 13:14 -0700, Jerry Snitselaar wrote: > Jerry Snitselaar @ 2020-12-02 23:11 MST: [...] > > The interrupt storm detection code works on the T490s. I'm not sure > > what is going on with the L490. I will see if I can get access to > > one. > > > > Jerry > > Lenovo verified that the L490 hangs. Just to confirm, that's this system: https://www.lenovo.com/us/en/laptops/thinkpad/thinkpad-l/ThinkPad-L490/p/22TP2TBL490 We could ask if lenovo will give us one, but if not we could pull a Jens. [the backstory is that when Jens was doing queueing in the block layer, there were lots of SATA devices that didn't work quite right but you couldn't tell unless you actually tried them out. Getting manufacturers to send samples is rather arduous, so he took to ordering them online, testing them out, and then returning them for a full refund within the allowed window] It looks like Lenovo has a nice christmas returns policy: https://www.lenovo.com/us/en/shopping-faq/#returns James