Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Dec 2020 23:01:45 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     "Winkler, Tomas" <tomas.winkler@intel.com>,
        "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Wang, Yu1" <yu1.wang@intel.com>,
        "Liu, Shuo A" <shuo.a.liu@intel.com>,
        "virtio-dev@lists.oasis-open.org" <virtio-dev@lists.oasis-open.org>
Subject: Re: [char-misc-next 13/13] mei: virtio: virtualization frontend
 driver
Message-ID: <X8lgSb9vB6UoJbVB@kroah.com>
References: <20200818115147.2567012-1-tomas.winkler@intel.com>
 <20200818115147.2567012-14-tomas.winkler@intel.com>
 <20201125160326-mutt-send-email-mst@kernel.org>
 <7f6181d8e80d4efb9464e9ec436800b7@intel.com>
 <20201203164859-mutt-send-email-mst@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201203164859-mutt-send-email-mst@kernel.org>
Precedence: bulk

On Thu, Dec 03, 2020 at 04:51:10PM -0500, Michael S. Tsirkin wrote:
> On Wed, Nov 25, 2020 at 09:18:04PM +0000, Winkler, Tomas wrote:
> > > 
> > > On Tue, Aug 18, 2020 at 02:51:47PM +0300, Tomas Winkler wrote:
> > > > +#ifndef VIRTIO_ID_MEI
> > > > +#define VIRTIO_ID_MEI 0xFFFE /* virtio mei */ #endif
> > > 
> > > Just noticed now that this driver landed upstream.  Can I ask that you guys
> > > please register IDs with the virtio TC and not just pick a number at random?
> > > In particular this is way outside allowed range.
> > > 
> > > IDs should also be listed in include/uapi/linux/virtio_ids.h
> > > 
> > > If people just pick random numbers like this collistions are unavoidable.
> > > 
> > > List of IDs is part of virtio spec, chapter "Device Types".
> > > 
> > > Please do this change now before this goes out to production!
> > Okay,  this was assigned by ACRN, my impression was it's already registered.
> > Will take care of.
> > Thanks
> > Tomas
> 
> Well nothing happened yet.
> 
> I think at this point we really should revert this patch before Linux is
> released so in the next version the correct ID can be used instead of a reserved one.
> Otherwise Linux will be stuck supporting this forever and will conflict
> with hypervisors using this for what this range is for which is
> experimental use.
> 
> Greg, any opinion on that?

I will be glad to revert it, what's the git commit id?

thanks,

greg k-h