Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vadim Pasternak <vadimp@nvidia.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        "Mark Gross" <mgross@linux.intel.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Michael Shych <michaelsh@mellanox.com>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "clang-built-linux@googlegroups.com" 
        <clang-built-linux@googlegroups.com>
Subject: RE: [PATCH] platform/x86: mlx-platform: remove an unused variable
Thread-Topic: [PATCH] platform/x86: mlx-platform: remove an unused variable
Thread-Index: AQHWycQJ+tzIskPouEih6zwvYYhQc6nmAPMg
Date:   Thu, 3 Dec 2020 23:17:07 +0000
Message-ID: <DM6PR12MB38987FFE8C575364D7FE3AF0AFF20@DM6PR12MB3898.namprd12.prod.outlook.com>
References: <20201203223105.1195709-1-arnd@kernel.org>
In-Reply-To: <20201203223105.1195709-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f4dcc74f-6565-4120-98a2-08d897e18da0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2020 23:17:07.1443
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kEwdWZKXCAaVJ0dWSdO25mqM3w1JbfTYJ4TMB79HuwFA2J740N5yGtDcFysl5J68BpVmv2jlvoYIW5ogba7YEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2666
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1607037430; bh=ZW9yuT+Q1cdqUVx35EXXs3sUuVIi2ZR7RcGAZCuDT5E=;
        h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:
         CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:
         In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach:
         X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
         x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
         x-ms-traffictypediagnostic:x-microsoft-antispam-prvs:
         x-ms-exchange-transport-forked:x-ms-oob-tlc-oobclassifiers:
         x-ms-exchange-senderadcheck:x-microsoft-antispam:
         x-microsoft-antispam-message-info:x-forefront-antispam-report:
         x-ms-exchange-antispam-messagedata:Content-Type:
         Content-Transfer-Encoding:MIME-Version:
         X-MS-Exchange-CrossTenant-AuthAs:
         X-MS-Exchange-CrossTenant-AuthSource:
         X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-originalarrivaltime:
         X-MS-Exchange-CrossTenant-fromentityheader:
         X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
         X-MS-Exchange-CrossTenant-userprincipalname:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
        b=AUPLKY/0Cf8pVBIfUHIJ7cPJ/B/+NtyQ+Cbu/03SV6KYJm5Pjo+mpGVOfHxovPTfu
         VQyXiqrIwCdM2uni+1ut1SvkDwQ4zCnX3x0Yi8gwWYTP+h5zU7YVgHiTFD0PLQS6LR
         GmIJiu7GdF4nVZbt3k22ugmARoK1qrekbCxDTAMuX9FxcDSKfvdquLbeTqVNhJTgEJ
         cBrvuskLGI5vSTVnHQpUjj19hpWcQbUQTp3fDhu6kI8PLrTbByP6jXGDELArsr2ur+
         J1+ttvygcG0eNpj2TwRK0DwCDTSEiZjsU1RXr9tbCgkuvF5wWWyYDfNw2tCX7XQIAQ
         ntahGuCKj8+JA==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Friday, December 04, 2020 12:31 AM
> To: Vadim Pasternak <vadimp@nvidia.com>; Hans de Goede
> <hdegoede@redhat.com>; Mark Gross <mgross@linux.intel.com>; Nathan
> Chancellor <natechancellor@gmail.com>; Nick Desaulniers
> <ndesaulniers@google.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Michael Shych
> <michaelsh@mellanox.com>; platform-driver-x86@vger.kernel.org; linux-
> kernel@vger.kernel.org; clang-built-linux@googlegroups.com
> Subject: [PATCH] platform/x86: mlx-platform: remove an unused variable
>=20
> From: Arnd Bergmann <arnd@arndb.de>

Acked-by: Vadim Pasternak <vadimp@nvidia.com>

>=20
> The only reference to the mlxplat_mlxcpld_psu[] array got removed, so the=
re is
> now a warning from clang:
>=20
> drivers/platform/x86/mlx-platform.c:322:30: error: variable
> 'mlxplat_mlxcpld_psu' is not needed and will not be emitted [-Werror,-
> Wunneeded-internal-declaration]
> static struct i2c_board_info mlxplat_mlxcpld_psu[] =3D {
>=20
> Remove the array as well and adapt the ARRAY_SIZE() call accordingly.
>=20
> Fixes: 912b341585e3 ("platform/x86: mlx-platform: Remove PSU EEPROM from
> MSN274x platform configuration")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/platform/x86/mlx-platform.c | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
>=20
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/m=
lx-
> platform.c
> index 598f44558764..6a634b72bfc2 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -319,15 +319,6 @@ static struct i2c_mux_reg_platform_data
> mlxplat_extended_mux_data[] =3D {  };
>=20
>  /* Platform hotplug devices */
> -static struct i2c_board_info mlxplat_mlxcpld_psu[] =3D {
> -	{
> -		I2C_BOARD_INFO("24c02", 0x51),
> -	},
> -	{
> -		I2C_BOARD_INFO("24c02", 0x50),
> -	},
> -};
> -
>  static struct i2c_board_info mlxplat_mlxcpld_pwr[] =3D {
>  	{
>  		I2C_BOARD_INFO("dps460", 0x59),
> @@ -456,7 +447,7 @@ static struct mlxreg_core_item
> mlxplat_mlxcpld_default_items[] =3D {
>  		.aggr_mask =3D MLXPLAT_CPLD_AGGR_PSU_MASK_DEF,
>  		.reg =3D MLXPLAT_CPLD_LPC_REG_PSU_OFFSET,
>  		.mask =3D MLXPLAT_CPLD_PSU_MASK,
> -		.count =3D ARRAY_SIZE(mlxplat_mlxcpld_psu),
> +		.count =3D
> ARRAY_SIZE(mlxplat_mlxcpld_default_psu_items_data),
>  		.inversed =3D 1,
>  		.health =3D false,
>  	},
> @@ -495,7 +486,7 @@ static struct mlxreg_core_item
> mlxplat_mlxcpld_comex_items[] =3D {
>  		.aggr_mask =3D MLXPLAT_CPLD_AGGR_MASK_CARRIER,
>  		.reg =3D MLXPLAT_CPLD_LPC_REG_PSU_OFFSET,
>  		.mask =3D MLXPLAT_CPLD_PSU_MASK,
> -		.count =3D ARRAY_SIZE(mlxplat_mlxcpld_psu),
> +		.count =3D
> ARRAY_SIZE(mlxplat_mlxcpld_default_psu_items_data),
>  		.inversed =3D 1,
>  		.health =3D false,
>  	},
> --
> 2.27.0