Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20201203231232.1482792-1-arnd@kernel.org>
References: <20201203231232.1482792-1-arnd@kernel.org>
Subject: Re: [PATCH] coresight: remove broken __exit annotations
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tingwei Zhang <tingwei@codeaurora.org>,
        Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
        Mian Yousaf Kaukab <ykaukab@suse.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
To:     Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnd Bergmann <arnd@kernel.org>,
        Kim Phillips <kim.phillips@arm.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>
Date:   Thu, 03 Dec 2020 16:04:52 -0800
Message-ID: <160704029234.1580929.9183785406117157105@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Arnd Bergmann (2020-12-03 15:11:40)
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> Functions that are annotated __exit are discarded for built-in drivers,
> but the .remove callback in a device driver must still be kept around
> to allow bind/unbind operations.
>=20
> There is now a linker warning for the discarded symbol references:
>=20
> `tmc_remove' referenced in section `.data' of drivers/hwtracing/coresight=
/coresight-tmc-core.o: defined in discarded section `.exit.text' of drivers=
/hwtracing/coresight/coresight-tmc-core.o
> `tpiu_remove' referenced in section `.data' of drivers/hwtracing/coresigh=
t/coresight-tpiu.o: defined in discarded section `.exit.text' of drivers/hw=
tracing/coresight/coresight-tpiu.o
> `etb_remove' referenced in section `.data' of drivers/hwtracing/coresight=
/coresight-etb10.o: defined in discarded section `.exit.text' of drivers/hw=
tracing/coresight/coresight-etb10.o
> `static_funnel_remove' referenced in section `.data' of drivers/hwtracing=
/coresight/coresight-funnel.o: defined in discarded section `.exit.text' of=
 drivers/hwtracing/coresight/coresight-funnel.o
> `dynamic_funnel_remove' referenced in section `.data' of drivers/hwtracin=
g/coresight/coresight-funnel.o: defined in discarded section `.exit.text' o=
f drivers/hwtracing/coresight/coresight-funnel.o
> `static_replicator_remove' referenced in section `.data' of drivers/hwtra=
cing/coresight/coresight-replicator.o: defined in discarded section `.exit.=
text' of drivers/hwtracing/coresight/coresight-replicator.o
> `dynamic_replicator_remove' referenced in section `.data' of drivers/hwtr=
acing/coresight/coresight-replicator.o: defined in discarded section `.exit=
.text' of drivers/hwtracing/coresight/coresight-replicator.o
> `catu_remove' referenced in section `.data' of drivers/hwtracing/coresigh=
t/coresight-catu.o: defined in discarded section `.exit.text' of drivers/hw=
tracing/coresight/coresight-catu.o
>=20
> Remove all those annotations.
>=20
> Fixes: 8b0cf82677d1 ("coresight: stm: Allow to build coresight-stm as a m=
odule")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>