Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: bbhatt=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 03 Dec 2020 17:43:42 -0800
From:   Bhaumik Bhatt <bbhatt@codeaurora.org>
To:     Hemant Kumar <hemantk@codeaurora.org>
Cc:     manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
        loic.poulain@linaro.org, jhugo@codeaurora.org,
        linux-kernel@vger.kernel.org, hemantk=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v3 1/7] bus: mhi: core: Allow receiving a STOP channel
 command response
Organization: Qualcomm Innovation Center, Inc.
Reply-To: bbhatt@codeaurora.org
Mail-Reply-To: bbhatt@codeaurora.org
In-Reply-To: <6668b99c-a1a7-920a-4a7e-e2cb2729baee@codeaurora.org>
References: <1606952438-15321-1-git-send-email-bbhatt@codeaurora.org>
 <1606952438-15321-2-git-send-email-bbhatt@codeaurora.org>
 <6668b99c-a1a7-920a-4a7e-e2cb2729baee@codeaurora.org>
Message-ID: <fbc578fa720b6f492d77c64efdb80e67@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2020-12-02 04:15 PM, Hemant Kumar wrote:
> Hi Bhaumik,
> 
> On 12/2/20 3:40 PM, Bhaumik Bhatt wrote:
>> Add support to receive the response to a STOP channel command to the
> How about saying "Add support to send the STOP channel command ?
Addressed in v4.
>> MHI bus. If a client would like to STOP a channel instead of issuing
>> a RESET to it, this would provide support for it.
>> 
>> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
>> ---
>>   drivers/bus/mhi/core/main.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>> 
>> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
>> index 702c31b..a7bb8a7 100644
>> --- a/drivers/bus/mhi/core/main.c
>> +++ b/drivers/bus/mhi/core/main.c
>> @@ -1193,6 +1193,11 @@ int mhi_send_cmd(struct mhi_controller 
>> *mhi_cntrl,
>>   		cmd_tre->dword[0] = MHI_TRE_CMD_RESET_DWORD0;
>>   		cmd_tre->dword[1] = MHI_TRE_CMD_RESET_DWORD1(chan);
>>   		break;
>> +	case MHI_CMD_STOP_CHAN:
>> +		cmd_tre->ptr = MHI_TRE_CMD_STOP_PTR;
>> +		cmd_tre->dword[0] = MHI_TRE_CMD_STOP_DWORD0;
>> +		cmd_tre->dword[1] = MHI_TRE_CMD_STOP_DWORD1(chan);
>> +		break;
>>   	case MHI_CMD_START_CHAN:
>>   		cmd_tre->ptr = MHI_TRE_CMD_START_PTR;
>>   		cmd_tre->dword[0] = MHI_TRE_CMD_START_DWORD0;
>> 
> 
> Thanks,
> Hemant

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project