Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Liu Ying <victor.liu@nxp.com>
To:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        a.hajda@samsung.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm
Subject: [PATCH 1/4] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()
Date:   Fri,  4 Dec 2020 15:33:41 +0800
Message-Id: <1607067224-15616-2-git-send-email-victor.liu@nxp.com>
In-Reply-To: <1607067224-15616-1-git-send-email-victor.liu@nxp.com>
References: <1607067224-15616-1-git-send-email-victor.liu@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (119.31.174.66) by SG2PR01CA0098.apcprd01.prod.exchangelabs.com (2603:1096:3:15::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3632.17 via Frontend Transport; Fri, 4 Dec 2020 07:42:01 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: db29b7c2-516d-419c-12f6-08d8982819d7
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3421:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB3421CB61935A70BBFE126EE598F10@VI1PR0402MB3421.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: /0+Yjp6pbosezozu9svnkWtxsc38PFDPxKhweML4r2T3abEK9+sLTf+1AdqpuODnc2n5Nv2q21HbnuoNMZQJ/qLu1S6SnRSe/yDCC/55ZJ9CrJrG2kN3AJiP2F51JHxaTwTPRoq3HTMQXUSuQq9gyoY7I8qnhyJSva7oK1owGPrA6rKbaP/HHNHT7zaaoi7k+63iSXOY7qX3P5mWKXh4J7KuVg9LA5MZOOOwe/vsNl2Omut2A9qCSBOfBO+Ntss9snnQ+nOCZ5xx+4PduPO/L7pBWm1rJBMjgD0hHz6UwakPM9KvZ3Zw75XYcVo6Tu4lklisyIwya2Uld9mi+Hgh2g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB3983.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(4326008)(66556008)(6512007)(66476007)(66946007)(316002)(8676002)(36756003)(7416002)(2906002)(86362001)(6486002)(8936002)(26005)(186003)(52116002)(16526019)(2616005)(956004)(478600001)(6666004)(5660300002)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WGFSSGlucnFQR0hCQjN4RVVhbHBnVXdEL3c0SityUGRqYXk0K0RGV0Q3Mmpy?=
 =?utf-8?B?ekN5VDdiZlR6MmdpeFMycGdkc2dEK241UTVBWE54aW55QmxhQS8rTFFETFVZ?=
 =?utf-8?B?b2t4N0c0WmFmbkZwd2M4d3ltZzBmejdBdUp6cGo5bkZheUphaEV0dVhKRGJ3?=
 =?utf-8?B?THNldDdqRjU2eFdIVXVnRDl2VFN2RXB0WkxUR2V6VENaSGRuNkRrYnZTOUF3?=
 =?utf-8?B?Q0lxS2phVnJzK09aQTVlODZ1bSs0WlFRN0dLajFZNFFxQkp5OG81djdiSnRN?=
 =?utf-8?B?NHM1NUZ6NTFtTzNiM0JXK0loZnI5WVU4VXk3UVc1eUFsV0xMTUZscWgzbkQ1?=
 =?utf-8?B?K0ZiaG1LbTBXZG1KKzhqUEZDcC84MUNkUmRjSkRxdWJUWHM0d3VtZS92dDZP?=
 =?utf-8?B?RTdnS2JKZnlyUVMybE9uUU5oNDdzQjhGZTMwbjAwSW1GTjBQTUo3eFNNUFFi?=
 =?utf-8?B?TTJTNUVGQ0k4TmpFWDdDSGtTaGRkekR0OFdhcEY1RDRjZWtFWG5uTWZqa1Y4?=
 =?utf-8?B?Y0FtWkhvWU5CRWZabUt6TG5XRXhBZzBSakd5a2tNWmNZU3NJeVkxRFh0Y1Va?=
 =?utf-8?B?djRRelBOUU9HZE5XYTJVd0J3TElqemVkL3pOdzBJdzlCVHB3SEpDZFY4dlZP?=
 =?utf-8?B?aytOcW13WFEzWVREa2hJM2trVklYRkFnZWNuUndueWkrU1QzSi81NW9ubjNT?=
 =?utf-8?B?Z1pLOENiTG1IK0pwSWtFc3NUS0ZJM2FmWWlrMHBsWjg2M3AzM3pNVnBYQkZX?=
 =?utf-8?B?ZVcrTUVQUXpQaWd6TnlMNzRQOE1XNEZRUUhVWVVleEs2eEswa2pxdHpjbnlk?=
 =?utf-8?B?eFRzVzVEZ09NcFRlWVlDT1hzRzYxSExCM2xTazVBelFNdTNpcHFUUXVzb1kx?=
 =?utf-8?B?KzVTeERsTXFDVnE0MG94ejBDemg3L1pMOEw4OVN0bUYydjhIWGhNanVwSDlO?=
 =?utf-8?B?cEFmSllIdVloMVRibmRxVUZWQ2pNZjZQa1ZJYXl2MDlKZmdYTzUwc3Nieldt?=
 =?utf-8?B?elVGRDhubE40VEV4UzJCckVzYnJPL01PVEtVYjBKQ1JleHl5cEhTcU9MKy9W?=
 =?utf-8?B?ZjliQW5UTjhCSGlmek96NVk3VUp5MkVIYnNjbUl5SS9oZzJJR3RsYkNmdElX?=
 =?utf-8?B?M1hFV3FmbklmSFEvTGxDaDZIZWwwVnNzamxmYTZJczhqSlRDMTZZQkdTL0k0?=
 =?utf-8?B?Tyt3Rkt2RkRWTGIvM0FMNnpTYWhxZVRub2ZiZnZ3WWMrNnFkdVNNL09qdlFB?=
 =?utf-8?B?cGVhUFYyNEswc2RrR2liSnpxOEpiY0VGZkdoZllEZFk2RWplaDdpT25yejhM?=
 =?utf-8?Q?ULsbalJswdfFlcwdwFj+8bNqKDkdiNdNjG?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db29b7c2-516d-419c-12f6-08d8982819d7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3983.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2020 07:42:07.5692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9xf7cy49ghIJzeGKpo9WfZIqKjKirSnTbumzD9Xt0a43mYesV3mn+snEM8rGIPA8h3uVZw+QNvgKmdsgh7kv/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3421
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
works with a Mixel MIPI DPHY + LVDS PHY combo to support either
a MIPI DSI display or a LVDS display.  So, this patch calls
phy_set_mode() from nwl_dsi_enable() to set PHY mode to MIPI DPHY
explicitly.

Cc: Guido Günther <agx@sigxcpu.org>
Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index 66b6740..be6bfc5 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -678,6 +678,12 @@ static int nwl_dsi_enable(struct nwl_dsi *dsi)
 		return ret;
 	}
 
+	ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
+	if (ret < 0) {
+		DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret);
+		goto uninit_phy;
+	}
+
 	ret = phy_configure(dsi->phy, phy_cfg);
 	if (ret < 0) {
 		DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);
-- 
2.7.4