Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp208067pxu; Fri, 4 Dec 2020 00:59:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzOSdSpjpe0o0JbzXrIo7/QkKB7WyOwGaCruxJffOE6tmfRN/KWaJDuOCkXM/J58YDEO6GN X-Received: by 2002:a17:906:a218:: with SMTP id r24mr5943834ejy.372.1607072363586; Fri, 04 Dec 2020 00:59:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607072363; cv=none; d=google.com; s=arc-20160816; b=qfs8FUc/hQ71KNDo33Glcsh2CA3RH8kkaT4wA0K+XRnujs/g7iqtm86ie4oeDaHWED 4Vzigd71XWlu6R8443GZeS+A40EUdFAl1VgBfSkXNNmMTOv65IlDABs1J5hL2d+BdI9z y736eXd6ijjeG8b0X+RRbTBwK6D0FWrajfkxWi1T9UkiYHjvxfrVPln8HdyPcLnj5VzI 3qFI2Jy86HmZe61KOjlTAjQeevNg2+hVvQQ4JHWWPJGtJhIb8GL848U12oYXTJUmytoD EvEpkiSZBJcyvc/nhwhbnNBCRdzYZ6+P5hBvtCA/dvaoLG49MwsgyxIXBwd0jz3VbbK0 HKWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=QJ1fzSgokECotHkJqrqoEExwA9TcEVBR3NXKHiATO2k=; b=h9VIJeiy2aUGb2qi6qR7WJFiTpwGif/wi8v6/zCRmdbVcdh1bYcY7YOOWsa5s3kDJl /6EkbGtxi0TjbvwSrSVCvNR5LejOzt/3nC9ZKGzmLLwm5mQF7FFXMPAfdpYRPNYFtgGw QFSaukeqJRa14GBXZ7blSVnCpWfDE+5q4UY5yFHK/mJ7BXw758jGNSEoopCPIRALLJZ4 q5eJNEMWqLOhvdxRbKgAeSL4F7Y3szy59G+C/HEWVVe2GOI8e3wuvIK3Ohv7RMZtjBwt Xwi8KJjMjBEBtLXytHVtdlxmjaUHGURcAtFvo1Mw2DpHDqhi5TLRqaz3SsHD/t3PBKvU VIUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F25LgDPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p10si1005174eji.254.2020.12.04.00.59.00; Fri, 04 Dec 2020 00:59:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F25LgDPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728854AbgLDI5R (ORCPT + 99 others); Fri, 4 Dec 2020 03:57:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727479AbgLDI5Q (ORCPT ); Fri, 4 Dec 2020 03:57:16 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3547FC061A4F for ; Fri, 4 Dec 2020 00:56:36 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id f24so5688220ljk.13 for ; Fri, 04 Dec 2020 00:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QJ1fzSgokECotHkJqrqoEExwA9TcEVBR3NXKHiATO2k=; b=F25LgDPjFaoPG6Z/ATemnbUuP/kjWPbnEGqwOjyHQo/acXnkeeuM8cjCK5QrMUOkYh b5O+dla/oPbcOCpTfKP50n5QYlK7rVWmZILqvt6ri4S/iG8DHLvDg4vcH9eLyuU0unyZ yl2+ESuXjkamk8opnNNQaNTowDZ3C3T0HU0qALdXJmyGvX4dM9hNaKt+1e8mJj/yx2mZ yiOdYvnZ1tk2YlO8+UEWH73aJQ4XmTkgN6eIiweqCCcHIWCmuq5VxBNqoS3fBu+ED1SY gcu84AXBxNp/xnT9GUuaAcxIb5e7VIHxyJh1pcbeaXRT82zUm3XYjzhBiDviH5CQJ8JA +Nug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QJ1fzSgokECotHkJqrqoEExwA9TcEVBR3NXKHiATO2k=; b=jOrYmVTPsMKktXBaCPSHA6mgvd6KAWzFrDwyAdF0+YKPM5B1ZihlO1MC/AfIvKYBX5 SM1QQlCayuoKyw457EQ8XZqjQ17IuViMxTAjRkcWxLNmuzCBnd4WLNYhb7FtltyeHAO6 U2Md8vUkdgaowpWS/eIRVusoOYgup8SDjF7Ca1bQpzjJeoIW6COLVp1SsabHPbETnKwu xo/W6UFB6A+FPybyBmLBZSVxaM1V3vuGDQqC41qeFAW9aMxrLjn5vkA5H7xVh/RGsYPR Ubuovp2/MxxIIfrLI0uaMxLPa/afpsxCXCqf9EvqMT5AO2nTp4Kgr6X7pP/hCu3008AG vPYw== X-Gm-Message-State: AOAM531BAKHx/4oNZWi2EOXw5DJ4OXRuvEnWE+nMW2xsiR8NTfVaVfga Q38bT22CLfk9AMP48eo44RX4wO6sStW4ar34sZlmzQ== X-Received: by 2002:a05:651c:39d:: with SMTP id e29mr2768490ljp.144.1607072194779; Fri, 04 Dec 2020 00:56:34 -0800 (PST) MIME-Version: 1.0 References: <1606218173-3722-1-git-send-email-zou_wei@huawei.com> In-Reply-To: <1606218173-3722-1-git-send-email-zou_wei@huawei.com> From: Linus Walleij Date: Fri, 4 Dec 2020 09:56:23 +0100 Message-ID: Subject: Re: [PATCH -next] pinctrl: pinctrl-microchip-sgpio: Mark some symbols with static keyword To: Zou Wei Cc: Lars Povlsen , Steen Hegelund , Microchip Linux Driver Support , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 12:31 PM Zou Wei wrote: > Fix the following sparse warnings: > > drivers/pinctrl/pinctrl-microchip-sgpio.c:63:31: warning: symbol 'properties_luton' was not declared. Should it be static? > drivers/pinctrl/pinctrl-microchip-sgpio.c:68:31: warning: symbol 'properties_ocelot' was not declared. Should it be static? > drivers/pinctrl/pinctrl-microchip-sgpio.c:73:31: warning: symbol 'properties_sparx5' was not declared. Should it be static? > > Signed-off-by: Zou Wei Patch applied, thanks Zou! Yours, Linus Walleij