Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751250AbWH3Rvl (ORCPT ); Wed, 30 Aug 2006 13:51:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751255AbWH3Rvl (ORCPT ); Wed, 30 Aug 2006 13:51:41 -0400 Received: from mx1.redhat.com ([66.187.233.31]:38829 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751250AbWH3Rvl (ORCPT ); Wed, 30 Aug 2006 13:51:41 -0400 Subject: Re: [PATCH] SELinux: work around filesystems which call d_instantiate before setting inode mode From: Eric Paris To: Steve French Cc: jmorris@redhat.com, linux-kernel@vger.kernel.org, shaggy@austin.ibm.com, shirishp@us.ibm.com, akpm@osdl.org In-Reply-To: <44F50D86.8050706@austin.rr.com> References: <44F50D86.8050706@austin.rr.com> Content-Type: text/plain Date: Wed, 30 Aug 2006 13:52:32 -0400 Message-Id: <1156960352.3195.56.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.2 (2.6.2-1.fc5.5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 25 On Tue, 2006-08-29 at 23:01 -0500, Steve French wrote: > Eric, > Does this patch do what you need? > > It rearranges the cifs call to d_instantiate until after the inode is > filled in in fs/cifs/readdir.c > which IIRC was the only place which did the reverse order from what you > expected (at > least the only place in cifs). I will try it tomorrow but I don't know > SE Linux > scenarios to try that would prove whether it works. This patch does seem to solve the issue with CIFS that we were experiencing and I would love to see it submitted. I would also like to have my original patch included as it will help to flush out any other cases of this ordering in the future. -Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/