Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Eelco Chaudron" <echaudro@redhat.com>
To:     "Wang Hai" <wanghai38@huawei.com>
Cc:     pshelar@ovn.org, davem@davemloft.net, kuba@kernel.org,
        dev@openvswitch.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] openvswitch: fix error return code in
 validate_and_copy_dec_ttl()
Date:   Fri, 04 Dec 2020 13:07:48 +0100
Message-ID: <40A832BA-4065-4FB2-9C33-D41CF4B336CF@redhat.com>
In-Reply-To: <20201204114314.1596-1-wanghai38@huawei.com>
References: <20201204114314.1596-1-wanghai38@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Precedence: bulk


On 4 Dec 2020, at 12:43, Wang Hai wrote:

> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Changing 'return start' to 'return action_start' can fix this bug.
>
> Fixes: 69929d4c49e1 ("net: openvswitch: fix TTL decrement action 
> netlink message format")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>

Thanks for fixing!

Reviewed-by: Eelco Chaudron <echaudro@redhat.com>

> ---
>  net/openvswitch/flow_netlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/flow_netlink.c 
> b/net/openvswitch/flow_netlink.c
> index ec0689ddc635..4c5c2331e764 100644
> --- a/net/openvswitch/flow_netlink.c
> +++ b/net/openvswitch/flow_netlink.c
> @@ -2531,7 +2531,7 @@ static int validate_and_copy_dec_ttl(struct net 
> *net,
>
>  	action_start = add_nested_action_start(sfa, OVS_DEC_TTL_ATTR_ACTION, 
> log);
>  	if (action_start < 0)
> -		return start;
> +		return action_start;
>
>  	err = __ovs_nla_copy_actions(net, actions, key, sfa, eth_type,
>  				     vlan_tci, mpls_label_count, log);
> -- 
> 2.17.1