Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Dec 2020 13:08:16 +0100
From:   Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     Tiezhu Yang <yangtiezhu@loongson.cn>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 2/2] MIPS: Select ARCH_KEEP_MEMBLOCK to enable sysfs
 memblock debug
Message-ID: <20201204120816.GC10011@alpha.franken.de>
References: <1606965544-22611-1-git-send-email-yangtiezhu@loongson.cn>
 <1606965544-22611-3-git-send-email-yangtiezhu@loongson.cn>
 <9c9af0de-387b-f113-b0a2-c5767c31c16d@flygoat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9c9af0de-387b-f113-b0a2-c5767c31c16d@flygoat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Dec 03, 2020 at 11:58:51AM +0800, Jiaxun Yang wrote:
> 
> 
> 在 2020/12/3 上午11:19, Tiezhu Yang 写道:
> > In the current code, CONFIG_ARCH_KEEP_MEMBLOCK is not set for MIPS arch,
> > memblock_discard() will discard memory and reserved arrays if they were
> > allocated, select ARCH_KEEP_MEMBLOCK to give a chance to track "memory"
> > and "reserved" memblocks after early boot, with this patch, we can see
> > the following two sysfs interfaces under DEBUG_FS.
> > 
> > /sys/kernel/debug/memblock/memory
> > /sys/kernel/debug/memblock/reserved
> 
> Is this really necessary?
> memblock data is not really necessary after boot for non-debug purpose.
> 
> Given that MIPS is widely used in embedded systems which doesn't have much
> memory, keeping unused data after boot is kinda unconvincing.

about how much memory are talking here ?

> 
> If you intend to debug that please do it locally.

maybe we can add a

if DEBUG_KERNEL 

since enabling DEBUG_KERNEL will cost already some memory...

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]