Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Dec 2020 13:17:31 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Sowjanya Komatineni <skomatineni@nvidia.com>, jonathanh@nvidia.com,
        robh+dt@kernel.org, linux-spi@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v1 3/7] spi: qspi-tegra: Add support for Tegra210 QSPI
 controller
Message-ID: <X8oo23vly1SYKjbI@ulmo>
References: <1606857168-5839-1-git-send-email-skomatineni@nvidia.com>
 <1606857168-5839-4-git-send-email-skomatineni@nvidia.com>
 <20201202172721.GL5560@sirena.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="i8Lsqvp6HbXRxqD7"
Content-Disposition: inline
In-Reply-To: <20201202172721.GL5560@sirena.org.uk>
User-Agent: Mutt/2.0.2 (d9268908) (2020-11-20)
Precedence: bulk


--i8Lsqvp6HbXRxqD7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 02, 2020 at 05:27:21PM +0000, Mark Brown wrote:
> On Tue, Dec 01, 2020 at 01:12:44PM -0800, Sowjanya Komatineni wrote:
> > Tegra SoC has a Quad SPI controller starting from Tegra210.
> >=20
> > This patch adds support for Tegra210 QSPI controller.
>=20
> This looks pretty clean but I've got a few questions below about how
> this integrates with the frameworks as well as some more minor issues.
>=20
> > +config QSPI_TEGRA
> > +	tristate "Nvidia Tegra QSPI Controller"
>=20
> Everything else in this file is SPI_, even the qspi controllers.
>=20
> > +++ b/drivers/spi/qspi-tegra.c
> > @@ -0,0 +1,1418 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (C) 2020 NVIDIA CORPORATION.  All rights reserved.
> > + */
>=20
> Please make the entire comment a C++ one.  It also appears that the "All
> rights reserved" here conflicts with the GPL-2.0-only SPDX statement...

My understanding is that this phrase is pretty much irrelevant these
days. Furthermore, I don't think this is to be interpreted as a claim to
any rights other than the copyright, so it's mostly equivalent to the
"Copyright (C)" on that same line. Any license terms associated with the
file do still apply regardless.

That said, I'm not a lawyer, so don't take this as legal advice. FWIW,
there's something on the order of 8000 occurrences of that phrase in the
Linux kernel sources, so I think with or without the phrase we should be
okay.

Thierry

--i8Lsqvp6HbXRxqD7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl/KKNsACgkQ3SOs138+
s6H62Q/9Fwa6i9csrNhhvi0flxowro5rRfpFy86gUQp2HX2f6ZiJ3zsN33Q9RF1+
mH/dMXdPoLvIx9eBnr8YshoU37O03H8WyoA3rD0DWmZa6nEc9lLdS/00gF+5frWx
W0s8TkcE1fsK/83GceEPmiWWJ8+geOqzdpaEQEoIkxuu4IXhq5ba13HVpWf4Zsbd
uPAuZVwbeO5ZVn2cKqEIkMvNCeZmx0zlgvIY0huoIYyjqbRXfChz27jnayWxqzF8
ljszXMEEasNGY91u7KcxphYtlJohE05Gk/fs5GKVIytkQ2+GeiRkAuHNPIIWHX6R
FB2h7DlV/8/oMmPjjGtiSvoEk4qT/reSDLU5DBMIcMUr8AxHqVWkk++r8gNBh2SV
U3KsvJ8MnwZeHn6you+e9b5kKVYVXbZyMclbCWWIWx3aJtASuppLQU0KvI414akB
5OopHQbOruFf2+ubusKLz7ICD/ynQ+JixMkSCZ3eb6yXmctnb2KgfPccjYcsBUrS
fs3oGKJYC6O8/aD/Z/rUrgeTutxQsPL1l0J4hxsIOpTcHlXI6AoOfVeaalO2PCnp
AC3O5abTmGVfkOtV9quC5/0WW1lAiYE7vOfiCNiJc2fVtZ5ST/DvtQGt+7isLfcy
zxnRghHODNCk+eMPZpVsUIjanoU4z1fnly8tBK75TmahjtRHYdo=
=5NKQ
-----END PGP SIGNATURE-----

--i8Lsqvp6HbXRxqD7--