Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Claudiu Manoil <claudiu.manoil@nxp.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Ioana Ciornei <ioana.cionei@nxp.com>
CC:     Arnd Bergmann <arnd@arndb.de>, Michael Walle <michael@walle.cc>,
        Po Liu <po.liu@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] enetc: fix build warning
Thread-Topic: [PATCH] enetc: fix build warning
Thread-Index: AQHWycTyKaMdKSe1d0OiHw6Q5/4O0Knm2NiA
Date:   Fri, 4 Dec 2020 12:18:16 +0000
Message-ID: <DB8PR04MB67644946C4F1DAF8F8F38A4196F10@DB8PR04MB6764.eurprd04.prod.outlook.com>
References: <20201203223747.1337389-1-arnd@kernel.org>
In-Reply-To: <20201203223747.1337389-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7da71fe0-7b14-494f-bb5f-08d8984eadc3
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2020 12:18:16.2092
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bb5xMUSQxft4xzGpSqP9FVxVv/fLZUdltoFYugmeM1MpskXC8DZAljEl3suCAoYjn+5uz7mMhMykq5klrBp1FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6491
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>-----Original Message-----
>From: Arnd Bergmann <arnd@kernel.org>
>Sent: Friday, December 4, 2020 12:37 AM
[...]
>Subject: [PATCH] enetc: fix build warning
>
>From: Arnd Bergmann <arnd@arndb.de>
>
>When CONFIG_OF is disabled, there is a harmless warning about
>an unused variable:
>
>enetc_pf.c: In function 'enetc_phylink_create':
>enetc_pf.c:981:17: error: unused variable 'dev' [-Werror=3Dunused-variable=
]
>
>Slightly rearrange the code to pass around the of_node as a
>function argument, which avoids the problem without hurting
>readability.
>
>Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Very nice cleanup, the code looks much better like this.
For some reason this patch is marked as "Not applicable" in patchwork.
So I took the patch, made a small cosmetic change (see nit below), added a =
more
verbose subject line, tested and resent it, patchwork link here:
https://patchwork.ozlabs.org/project/netdev/patch/20201204120800.17193-1-cl=
audiu.manoil@nxp.com/

Thanks.

>---
> .../net/ethernet/freescale/enetc/enetc_pf.c   | 21 +++++++++----------
>@@ -1005,9 +1003,10 @@ static int enetc_pf_probe(struct pci_dev *pdev,
> 	struct net_device *ndev;
> 	struct enetc_si *si;
> 	struct enetc_pf *pf;
>+	struct device_node *node =3D pdev->dev.of_node;

Nit: move this long line to the top (reverse tree)