DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=HVosWp6HRCnTMBVZHWsKz5WQaDlTLyJ752p0W8ezIdTNvldWNn7SsGGilkABDH50BEeupkMbXR2zdVNvt95Os3MSy7DNNAQJRuqyOD7mw83lRGj1ADUWfrZV6PtDr+TrSjTwohDKptflnqm/h+Bw19mV9/tTer7Y4H9n8tVQv5Y=
Message-ID: <18d709710608301120i3b2b67fkecf455d842d3336d@mail.gmail.com>
Date: Wed, 30 Aug 2006 15:20:15 -0300
From: "Julio Auto" <mindvortex@gmail.com>
To: "David Wagner" <daw-usenet@taverner.cs.berkeley.edu>,
       schwidefsky@de.ibm.com
Subject: Re: [S390] cio: kernel stack overflow.
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <18d709710608301052u1307139dpf6e3b2da6e7bfcbe@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20060830124047.GA22276@skybase>
	 <ed4gno$d29$1@taverner.cs.berkeley.edu>
	 <18d709710608301052u1307139dpf6e3b2da6e7bfcbe@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 943
Lines: 19

On 8/30/06, Julio Auto <mindvortex@gmail.com> wrote:
> Unless, of course, the structure in question is kcalloc()'d (which is
> not the case of gdev in the beginning of the patch - I haven't had the
> time to check the other cases).

Sorry, actually gdev is kzalloc()'d (which works exactly kcalloc()
without the check for n*size integer overflows). I was looking at a
much older version of the code.

I still think, however, that memset()'ing to zero is still something
to consider, in the cases where the structure is passed to the routine
(as opposed to when it's _created by_ the routine). The code shouldn't
rely on the awareness of future developers when adding other calls to
these functions.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/